Avoid PodSecurityPolicy cleanup if the resource is not supported by Kubernetes API #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CharlyF
reviewed
Jan 19, 2023
pkg/kubernetes/platforminfo.go
Outdated
Comment on lines
99
to
100
| _, ok1 := platformInfo.apiOtherVersions["PodSecurityPolicy"] | ||
| _, ok2 := platformInfo.apiPreferredVersions["PodSecurityPolicy"] |
There was a problem hiding this comment.
nit: can we name these otherExists and preferredExists or something clearer than ok?
CharlyF
approved these changes
Jan 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 58.53% 58.65% +0.11%
==========================================
Files 149 149
Lines 17639 17650 +11
==========================================
+ Hits 10325 10352 +27
+ Misses 6700 6682 -18
- Partials 614 616 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Jan 19, 2023
khewonc
pushed a commit
that referenced
this pull request
Jan 20, 2023
…ubernetes API (#688) * Avoid PodSecurityPolicy cleanup if the resource is not supported by Kubernetes API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change addresses the Kubernetes 1.25 compatibility issue caused by Operator attempting to handle
PodDisruptionPolicyresource not available in aforementioned version.Operator 1.0.0 deployed on v1.25 would log following error on every reconcile
Motivation
Make Operator 1.0.0 run on v1.25.
Additional Notes
This change does not solve PSP usage across Operator.
PSP resource isn't utilized/implemented (see this) and only places attempting to handle PSP were resource cleanup routines. This PR changes the logic producing list of Kinds for the cleanup - it includes PSP only if it's supported by current Kubernetes version.
Once PSP resource implementation is done additional work will be need to control PSP creation.
Describe your test plan
Tested Kubernetes version 1.24, 1.25 using Kind cluster. Deployed agent locally, installed DDA v2 with DCA, CCR enabled - confirmed no errors are thrown.