Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to enable/disable DatadogAgent controller #731

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Mar 8, 2023

What does this PR do?

Adding a flag to control creation of DatadogAgent controller (and webhook), similar to what we have DatadogMonitor here.

Helm change an doc update to follow.

Motivation

#721

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

  • Set flag to false, build and deploy Operator.
  • Delete DatadogAgent CRD if exists.
  • Watch for any Operator errors.
  • Apply DatadogMonitor manifest, confirm monitor is created.

@levan-m levan-m assigned levan-m and unassigned levan-m Mar 8, 2023
@levan-m levan-m added the enhancement New feature or request label Mar 8, 2023
@levan-m levan-m added this to the v1.0.0 milestone Mar 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #731 (5c98b1c) into main (411a462) will increase coverage by 0.03%.
The diff coverage is 84.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   58.75%   58.79%   +0.03%     
==========================================
  Files         149      149              
  Lines       17814    17831      +17     
==========================================
+ Hits        10467    10484      +17     
- Misses       6727     6728       +1     
+ Partials      620      619       -1     
Flag Coverage Δ
unittests 58.79% <84.37%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/setup.go 56.52% <0.00%> (-4.42%) ⬇️
...ontrollers/datadogagent/merger/security_context.go 89.18% <100.00%> (+25.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e92251...5c98b1c. Read the comment docs.

@levan-m levan-m marked this pull request as ready for review March 15, 2023 14:13
@levan-m levan-m requested review from a team as code owners March 15, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants