Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode custom EDS rollingUpdate configuration #739

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Hardcode custom EDS rollingUpdate configuration #739

merged 1 commit into from
Mar 23, 2023

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Mar 22, 2023

What does this PR do?

Hardcoding custom values for EDS rollingUpdate settings since EDS defaults are restrictive (like maxUnavailable: 1).

This will produce

    rollingUpdate:
      maxParallelPodCreation: 50
      maxPodSchedulerFailure: 5%
      maxUnavailable: 5%
      slowStartAdditiveIncrease: 2%
      slowStartIntervalDuration: 5m0s

Motivation

Stalled EDS rollouts on large clusters.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Deployed locally, verified EDS manifest.

@levan-m levan-m requested review from a team as code owners March 22, 2023 20:31
github-actions[bot]
github-actions bot requested changes Mar 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@levan-m levan-m added the enhancement New feature or request label Mar 23, 2023
@levan-m levan-m added this to the v1.0.0 milestone Mar 23, 2023
@levan-m levan-m merged commit 63bc72b into main Mar 23, 2023
@levan-m levan-m deleted the levan-m/eds-rolling-update-defaults branch March 23, 2023 14:40
levan-m added a commit that referenced this pull request Mar 23, 2023
@levan-m
Hardcode custom EDS rollingUpdate configuration (#739)
4bf00ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlyF CharlyF CharlyF approved these changes

@github-actions GitHub Actions github-actions approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@levan-m @CharlyF