Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worflow release.yaml #748

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix worflow release.yaml #748

merged 1 commit into from
Apr 4, 2023

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Apr 3, 2023

What does this PR do?

Fix release process

Motivation

a previous replace-all eds->datadog makes an unattended update in this file.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@clamoriniere clamoriniere requested review from a team as code owners April 3, 2023 21:33
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@clamoriniere clamoriniere added the bug Something isn't working label Apr 3, 2023
@clamoriniere clamoriniere added this to the v1.0.0 milestone Apr 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #748 (9304422) into main (bd749fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   58.78%   58.78%           
=======================================
  Files         149      149           
  Lines       17895    17895           
=======================================
  Hits        10519    10519           
  Misses       6749     6749           
  Partials      627      627           
Flag Coverage Δ
unittests 58.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd749fd...9304422. Read the comment docs.

@CharlyF CharlyF modified the milestones: v1.0.0, v1.1.0 Apr 3, 2023
@CharlyF CharlyF merged commit bd905e9 into main Apr 4, 2023
@CharlyF CharlyF deleted the clamoriniere/fix-release branch April 4, 2023 13:00
CharlyF pushed a commit that referenced this pull request Apr 4, 2023
@CharlyF CharlyF modified the milestones: v1.1.0, v1.0.1 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants