Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Add inotify related syscalls to system-probe's seccomp profile #789

Merged
merged 1 commit into from
May 22, 2023

Conversation

Gui774ume
Copy link
Contributor

What does this PR do?

CWS uses inotify to watch a local directory that contains Security Profiles. The default seccomp profile of system-probe doesn't contain the syscalls required to use inotify. This PR adds those syscalls.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@Gui774ume Gui774ume added the bug Something isn't working label May 19, 2023
@Gui774ume Gui774ume requested review from a team as code owners May 19, 2023 10:52
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #789 (0874d4b) into main (1a113ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files         149      149           
  Lines       17990    17990           
=======================================
  Hits        10556    10556           
  Misses       6805     6805           
  Partials      629      629           
Flag Coverage Δ
unittests 58.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a113ab...0874d4b. Read the comment docs.

@khewonc khewonc added this to the v1.1.0 milestone May 19, 2023
@CharlyF CharlyF merged commit 5a8b8a1 into main May 22, 2023
@CharlyF CharlyF deleted the will/system-probe-inotify-seccomp branch May 22, 2023 16:19
@khewonc khewonc modified the milestones: v1.1.0, v1.0.3 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants