Pass existing DS to updateDaemonSetStatus in updateDaemonSet when no change is required #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #93
In
updateDaemonSet
, we create a new daemonset before checking if we need to make an update to the daemonset. Unfortunately, instead of passing the existing DS to theupdateDaemonSetStatus
method, we were passing the new one, which obviously had no containers running, resulting in the Agent having its status stuck inProgressing (0/0/0)
.Once we pass the existing DS, the status updates as expected.
Motivation
Fixing my own issue
Additional Notes