cloudformation: add parameter for forwarder bucket name #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow the user to specify a name for the forwarder bucket. This is necessary to avoid a circular dependency when creating permissions boundaries and passed them in via
PermissionsBoundaryArn
.From https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket.html
Motivation
Use case: I would like to create a permission boundary that limits datadog S3 privileges, but continue to allow unfettered access to the forwarder bucket (see https://github.com/DataDog/datadog-serverless-functions/blob/master/aws/logs_monitoring/template.yaml#L635-L646).
Before this change, the forwarder bucket's name is always generated, which makes it impossible to create the permission boundary before creating the forwarder bucket/role using cloudformation.
Testing Guidelines
I am forking it and running this within my own CloudFormation pipeline.
Types of changes
Check all that apply