Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): Fixing the release script for prod #825

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Jul 26, 2024

What does this PR do?

Fix wrong condition in release script and fix unclean git state when running release prod.

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
@ViBiOh ViBiOh requested a review from a team as a code owner July 26, 2024 15:29
@github-actions github-actions bot added the aws label Jul 26, 2024
exit 1
else
echo "Updating master"
git pull origin master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't pull master anymore in the subscript, the main release script is already doing it.

@ViBiOh ViBiOh merged commit 7ab511a into master Jul 29, 2024
13 checks passed
@ViBiOh ViBiOh deleted the vibioh/fix_prod_release branch July 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants