Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWSX] Fix waf events duplication #841

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

ge0Aja
Copy link
Contributor

@ge0Aja ge0Aja commented Sep 4, 2024

What does this PR do?

Fix WAF events processing which resulted in duplicating events due to iteration over a reversed list.
Iterate separately over WAF events list in the transformation step before iterating over the same list to process securityhub findings

/!\ Removed cfn-lint action in this PR to allow the CI to pass. The action seems to be broken
Screenshot 2024-09-04 at 14 56 37

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Sep 4, 2024
@ge0Aja ge0Aja marked this pull request as ready for review September 4, 2024 12:29
@ge0Aja ge0Aja requested a review from a team as a code owner September 4, 2024 12:29
@ViBiOh ViBiOh self-assigned this Sep 4, 2024
@ge0Aja ge0Aja merged commit f7ebadf into master Sep 4, 2024
13 checks passed
@ge0Aja ge0Aja deleted the georgi/fix-duplicate-waf branch September 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants