Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWSX][logs forwarder] Run cfn-lint as a pip package instead of an action #843

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[AWSX][logs forwarder] Run cfn-lint as a pip package instead of an action #843

merged 1 commit into from
Sep 4, 2024

Conversation

ge0Aja
Copy link
Contributor

@ge0Aja ge0Aja commented Sep 4, 2024 •
edited
Loading

What does this PR do?

install run cfn-lint using pip which allows to control the used version.
I've currently set the working version to 1.11.1 as the linter is broken starting version 1.12 see screenshot below
Screenshot 2024-09-04 at 14 56 37

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ge0Aja ge0Aja changed the title Run cfn-lint as a pip package [AWSX] [logs forwarder ]Run cfn-lint as a pip package instead of an action Sep 4, 2024
@ge0Aja ge0Aja changed the title [AWSX] [logs forwarder ]Run cfn-lint as a pip package instead of an action [AWSX] [logs forwarder] Run cfn-lint as a pip package instead of an action Sep 4, 2024
@ge0Aja ge0Aja changed the title [AWSX] [logs forwarder] Run cfn-lint as a pip package instead of an action [AWSX][logs forwarder] Run cfn-lint as a pip package instead of an action Sep 4, 2024
@ge0Aja ge0Aja marked this pull request as ready for review September 4, 2024 13:17
RaphaelAllier
RaphaelAllier approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@RaphaelAllier RaphaelAllier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ge0Aja ge0Aja merged commit 5fdf26e into master Sep 4, 2024
13 checks passed
@ge0Aja ge0Aja deleted the georgi/fix-cfn-lint branch September 4, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelAllier RaphaelAllier RaphaelAllier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ge0Aja @RaphaelAllier