Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarn version 3.4.1 #499

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Use yarn version 3.4.1 #499

merged 6 commits into from
Jun 26, 2023

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Follow-up on the migration of yarn, we want everyone to use the same version.

This commit fixes the yarn version for everyone, using similar approach that what was done for datadog-ci.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner June 23, 2023 15:18
@louiszawadzki louiszawadzki requested a review from a team as a code owner June 26, 2023 09:58
estherk15
estherk15 approved these changes Jun 26, 2023
View reviewed changes
Copy link

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review needed

@louiszawadzki louiszawadzki merged commit 90f1fa6 into develop Jun 26, 2023
3 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/migrate-to-modern-yarn branch June 26, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgouchet xgouchet xgouchet approved these changes

@0xnm 0xnm 0xnm approved these changes

@estherk15 estherk15 estherk15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@louiszawadzki @xgouchet @0xnm @estherk15