Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pack command after yarn upgrade #501

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

After upgrading yarn, the pack command broke as yarn now requires to use ** after directories in files for their content to be included.
Also the release content now does not include the directories, only the files, so the release content files had to be updated.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner June 27, 2023 09:49
Copy link

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

./check-release-content.sh -p packages/core/datadog-mobile-react-native-v$version.tgz > packages/core/release-content.txt
./check-release-content.sh -p packages/react-navigation/datadog-mobile-react-navigation-v$version.tgz > packages/react-navigation/release-content.txt
./check-release-content.sh -p packages/react-native-navigation/datadog-mobile-react-native-navigation-v$version.tgz > packages/react-native-navigation/release-content.txt
./check-release-content.sh -p packages/core/package.tgz > packages/core/release-content.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange that package name doesn't have module name and version anymore

@louiszawadzki louiszawadzki merged commit 1ce2c9d into develop Jun 28, 2023
3 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/fix-pack-command branch June 28, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants