Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version generation #520

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fix version generation #520

merged 1 commit into from
Aug 29, 2023

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Update the version.ts file with genversion when upgrading the SDK version.

This was broken when updating to yarn v3.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner August 29, 2023 14:03
@louiszawadzki louiszawadzki merged commit 96f4b40 into develop Aug 29, 2023
2 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/fix-version-generation branch August 29, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiszawadzki @0xnm