Add ability to disable additional ADO.NET Command Types (#6042 => v2) #6054

bouwkast · 2024-09-18T17:14:08Z

Summary of changes

Allows users to configure additionally ADO.NET DbCommands to be disabled so they won't have a Span created from them.

Reason for change

Since we instrument basically any DbCommand in ADO.NET this can lead to unwanted/duplicate Spans that customers have little control over. This allows for a comma-separated list of command type names that the .NET Tracer will not create a Span for if they encounter it.

Implementation details

Adds new Environment Variable DD_TRACE_DISABLED_ADONET_COMMAND_TYPES that accepts a comma-separated string of ADO.NET Command Type names that the Tracer will not create a Span for.

For example (some pseudo-code here):

Assuming we have a custom DbCommand FooDbCommand that we don't want Spans for ->

public class FooDbCommand : DbCommand
{
    ... class contents here
}

We'd need to set DD_TRACE_DISABLED_ADONET_COMMAND_TYPES to ->

DD_TRACE_DISABLED_ADONET_COMMAND_TYPES="FooDbCommand"

Test coverage

Extended current DbScopeFactoryTests to add new value.
Extended FakeCommandTests to include disabling of FakeCommand
Snapshotted those tests as well.

Other details

Merge the dd-go PR when this PR is merged: https://github.com/DataDog/dd-go/pull/150493

Backport of #6042

Co-authored-by: Lucas Pimentel <lucas.pimentel@datadoghq.com>

This reverts commit d34f2d0.

bouwkast · 2024-09-18T17:14:52Z

I've git cherry-picked my commits to this branch as I think we want a V2 of this instead of a V3 (ultimately both - maybe)

andrewlock · 2024-09-18T17:40:48Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6054) - mean (73ms)  : 65, 81
     .   : milestone, 73,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6054) - mean (1,056ms)  : 1031, 1082
     .   : milestone, 1056,
    master - mean (1,106ms)  : 1075, 1137
     .   : milestone, 1106,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6054) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6054) - mean (762ms)  : 739, 786
     .   : milestone, 762,
    master - mean (801ms)  : 783, 820
     .   : milestone, 801,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6054) - mean (92ms)  : 89, 96
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6054) - mean (710ms)  : 688, 732
     .   : milestone, 710,
    master - mean (746ms)  : 724, 768
     .   : milestone, 746,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6054) - mean (192ms)  : 187, 197
     .   : milestone, 192,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6054) - mean (1,139ms)  : 1112, 1166
     .   : milestone, 1139,
    master - mean (1,192ms)  : 1167, 1217
     .   : milestone, 1192,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6054) - mean (277ms)  : 272, 283
     .   : milestone, 277,
    master - mean (278ms)  : 274, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6054) - mean (920ms)  : 898, 942
     .   : milestone, 920,
    master - mean (963ms)  : 942, 984
     .   : milestone, 963,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6054) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6054) - mean (902ms)  : 879, 925
     .   : milestone, 902,
    master - mean (944ms)  : 916, 972
     .   : milestone, 944,

datadog-ddstaging · 2024-09-18T17:53:36Z

Datadog Report

Branch report: steven/29781-v2
Commit report: c4c7eae
Test service: dd-trace-dotnet

✅ 0 Failed, 350471 Passed, 1798 Skipped, 14h 57m 26.45s Total Time

language:dotnet was only added to all spans starting in V3.

andrewlock · 2024-09-18T19:29:00Z

Benchmarks Report for tracer 🐌

Benchmarks for #6054 compared to master:

1 benchmarks are faster, with geometric mean 1.124
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.68μs	43.5ns	292ns	0.0117	0.00389	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	56.5ns	357ns	0.0215	0.00539	0	5.61 KB
master	`StartStopWithChild`	net472	16.4μs	39.7ns	154ns	1.01	0.299	0.0889	6.05 KB
#6054	`StartStopWithChild`	net6.0	7.61μs	43.1ns	317ns	0.0151	0.00755	0	5.43 KB
#6054	`StartStopWithChild`	netcoreapp3.1	9.9μs	50.9ns	260ns	0.0192	0.00959	0	5.61 KB
#6054	`StartStopWithChild`	net472	16.7μs	89.6ns	723ns	1.01	0.287	0.0956	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	474μs	188ns	704ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	305ns	1.14μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	837μs	520ns	2.01μs	0.417	3.3 KB
#6054	`WriteAndFlushEnrichedTraces`	net6.0	472μs	179ns	645ns	0	2.7 KB
#6054	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	646μs	137ns	494ns	0	2.7 KB
#6054	`WriteAndFlushEnrichedTraces`	net472	836μs	872ns	3.38μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	196μs	1.1μs	8.57μs	0.187	18.45 KB
master	`SendRequest`	netcoreapp3.1	221μs	1.27μs	10.1μs	0.216	20.61 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6054	`SendRequest`	net6.0	197μs	1.13μs	9.41μs	0.191	18.45 KB
#6054	`SendRequest`	netcoreapp3.1	221μs	1.27μs	9.89μs	0.218	20.61 KB
#6054	`SendRequest`	net472	0.00107ns	0.000399ns	0.00155ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6054

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.82 KB	41.6 KB	-219 B	-0.52%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	567μs	2.98μs	14.3μs	0.553	0	0	41.82 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	2.5μs	9.34μs	0.334	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	net472	877μs	3.33μs	12.5μs	8.19	2.59	0.431	53.31 KB
#6054	`WriteAndFlushEnrichedTraces`	net6.0	561μs	2.83μs	12μs	0.566	0	0	41.6 KB
#6054	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	672μs	2.97μs	11.5μs	0.332	0	0	41.79 KB
#6054	`WriteAndFlushEnrichedTraces`	net472	886μs	4.14μs	16.6μs	8.21	2.28	0.456	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6054

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472	1.124	2,143.02	1,905.93

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.31μs	1.3ns	5.05ns	0.0145	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	2.3ns	8.92ns	0.0133	1.02 KB
master	`ExecuteNonQuery`	net472	2.15μs	2.63ns	10.2ns	0.156	987 B
#6054	`ExecuteNonQuery`	net6.0	1.19μs	0.718ns	2.78ns	0.0143	1.02 KB
#6054	`ExecuteNonQuery`	netcoreapp3.1	1.62μs	0.93ns	3.48ns	0.014	1.02 KB
#6054	`ExecuteNonQuery`	net472	1.91μs	1.89ns	7.06ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.21μs	1.1ns	4.25ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.48μs	0.908ns	3.52ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.66μs	7.72ns	29.9ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.33μs	1.37ns	4.92ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	1.56ns	5.85ns	0.0136	1.02 KB
master	`CallElasticsearchAsync`	net472	2.7μs	7.04ns	27.3ns	0.167	1.05 KB
#6054	`CallElasticsearch`	net6.0	1.14μs	0.458ns	1.77ns	0.0137	976 B
#6054	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.824ns	3.08ns	0.0132	976 B
#6054	`CallElasticsearch`	net472	2.57μs	0.977ns	3.66ns	0.157	995 B
#6054	`CallElasticsearchAsync`	net6.0	1.38μs	0.284ns	1.06ns	0.0131	952 B
#6054	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	1.06ns	3.97ns	0.0139	1.02 KB
#6054	`CallElasticsearchAsync`	net472	2.65μs	2.19ns	8.49ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.31μs	0.932ns	3.61ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.53μs	0.602ns	2.25ns	0.0133	952 B
master	`ExecuteAsync`	net472	1.83μs	0.725ns	2.81ns	0.145	915 B
#6054	`ExecuteAsync`	net6.0	1.3μs	0.904ns	3.5ns	0.0136	952 B
#6054	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.719ns	2.79ns	0.0121	952 B
#6054	`ExecuteAsync`	net472	1.84μs	0.931ns	3.61ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.27μs	1.28ns	4.62ns	0.0298	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.07μs	2.45ns	9.5ns	0.0355	2.76 KB
master	`SendAsync`	net472	7.67μs	1.8ns	6.97ns	0.5	3.15 KB
#6054	`SendAsync`	net6.0	4.34μs	9.86ns	35.6ns	0.0299	2.22 KB
#6054	`SendAsync`	netcoreapp3.1	5.09μs	1.83ns	7.09ns	0.0356	2.76 KB
#6054	`SendAsync`	net472	7.79μs	2.21ns	8.56ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.5μs	1.86ns	6.97ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.18μs	0.845ns	3.16ns	0.0218	1.64 KB
master	`EnrichedLog`	net472	2.59μs	1.85ns	7.18ns	0.25	1.57 KB
#6054	`EnrichedLog`	net6.0	1.45μs	1.64ns	6.37ns	0.0233	1.64 KB
#6054	`EnrichedLog`	netcoreapp3.1	2.14μs	1.76ns	6.58ns	0.0229	1.64 KB
#6054	`EnrichedLog`	net472	2.71μs	5.16ns	20ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	114μs	108ns	403ns	0.0566	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	119μs	232ns	897ns	0	0	4.28 KB
master	`EnrichedLog`	net472	146μs	103ns	398ns	0.659	0.22	4.46 KB
#6054	`EnrichedLog`	net6.0	113μs	138ns	536ns	0.056	0	4.28 KB
#6054	`EnrichedLog`	netcoreapp3.1	118μs	204ns	763ns	0.0592	0	4.28 KB
#6054	`EnrichedLog`	net472	146μs	146ns	546ns	0.659	0.22	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.91μs	1.01ns	3.77ns	0.0306	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.33μs	1.1ns	4.11ns	0.0282	2.2 KB
master	`EnrichedLog`	net472	5.14μs	2.54ns	9.82ns	0.319	2.02 KB
#6054	`EnrichedLog`	net6.0	3.09μs	1.45ns	5.62ns	0.0311	2.2 KB
#6054	`EnrichedLog`	netcoreapp3.1	4.21μs	1.57ns	5.86ns	0.03	2.2 KB
#6054	`EnrichedLog`	net472	4.81μs	1.48ns	5.71ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.38μs	0.585ns	2.26ns	0.0159	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.73μs	1.97ns	7.62ns	0.0156	0	1.14 KB
master	`SendReceive`	net472	1.96μs	0.852ns	3.3ns	0.183	0.000981	1.16 KB
#6054	`SendReceive`	net6.0	1.35μs	0.455ns	1.76ns	0.0161	0	1.14 KB
#6054	`SendReceive`	netcoreapp3.1	1.74μs	1.24ns	4.79ns	0.0146	0	1.14 KB
#6054	`SendReceive`	net472	2.09μs	0.982ns	3.81ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	0.945ns	3.54ns	0.0223	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.84μs	1.81ns	6.77ns	0.0229	1.65 KB
master	`EnrichedLog`	net472	4.37μs	1.79ns	6.92ns	0.323	2.04 KB
#6054	`EnrichedLog`	net6.0	2.75μs	0.769ns	2.88ns	0.0233	1.6 KB
#6054	`EnrichedLog`	netcoreapp3.1	3.95μs	1.66ns	6.45ns	0.0217	1.65 KB
#6054	`EnrichedLog`	net472	4.6μs	2.48ns	9.59ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	399ns	0.129ns	0.499ns	0.00816	576 B
master	`StartFinishSpan`	netcoreapp3.1	568ns	3.15ns	20.2ns	0.0078	576 B
master	`StartFinishSpan`	net472	670ns	2.34ns	8.77ns	0.0915	578 B
master	`StartFinishScope`	net6.0	482ns	0.23ns	0.861ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	722ns	0.692ns	2.68ns	0.00944	696 B
master	`StartFinishScope`	net472	845ns	0.592ns	2.29ns	0.105	658 B
#6054	`StartFinishSpan`	net6.0	410ns	0.537ns	2.08ns	0.00814	576 B
#6054	`StartFinishSpan`	netcoreapp3.1	568ns	0.987ns	3.82ns	0.00788	576 B
#6054	`StartFinishSpan`	net472	674ns	2.38ns	8.6ns	0.0915	578 B
#6054	`StartFinishScope`	net6.0	484ns	1.1ns	4.25ns	0.0097	696 B
#6054	`StartFinishScope`	netcoreapp3.1	692ns	0.842ns	3.26ns	0.00962	696 B
#6054	`StartFinishScope`	net472	893ns	2.23ns	8.33ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	682ns	0.353ns	1.37ns	0.00982	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	964ns	1.65ns	6.4ns	0.00957	696 B
master	`RunOnMethodBegin`	net472	1.14μs	4.41ns	17.1ns	0.104	658 B
#6054	`RunOnMethodBegin`	net6.0	655ns	0.582ns	2.25ns	0.00983	696 B
#6054	`RunOnMethodBegin`	netcoreapp3.1	923ns	2.52ns	9.42ns	0.00918	696 B
#6054	`RunOnMethodBegin`	net472	1.14μs	2.37ns	8.85ns	0.104	658 B

andrewlock · 2024-09-18T19:39:38Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6054) (11.105M)   : 0, 11104548
    master (11.241M)   : 0, 11241347
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6054) (7.507M)   : 0, 7506532
    master (7.436M)   : 0, 7436259
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.624M)   : 0, 7623650

    section Manual
    This PR (6054) (9.561M)   : crit ,0, 9561491
    master (11.144M)   : 0, 11143937

    section Manual + Automatic
    This PR (6054) (7.067M)   : 0, 7066818
    master (6.769M)   : 0, 6769336

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6054) (9.575M)   : 0, 9575480
    master (9.526M)   : 0, 9525943
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6054) (6.349M)   : 0, 6348517
    master (6.610M)   : 0, 6610089

    section Trace stats
    master (6.947M)   : 0, 6947051

    section Manual
    This PR (6054) (7.886M)   : crit ,0, 7886069
    master (9.627M)   : 0, 9627325

    section Manual + Automatic
    This PR (6054) (6.215M)   : 0, 6215389
    master (6.082M)   : 0, 6081694

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6054) (10.323M)   : 0, 10322743
    master (10.078M)   : 0, 10077851
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6054) (6.873M)   : 0, 6873156
    master (6.777M)   : 0, 6777224
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.294M)   : 0, 7293536

    section Manual
    This PR (6054) (8.796M)   : crit ,0, 8796428
    master (9.738M)   : 0, 9737534

    section Manual + Automatic
    This PR (6054) (6.589M)   : 0, 6588613
    master (6.208M)   : 0, 6208249

bouwkast · 2024-09-18T20:57:06Z

Adding do-not-merge as we are testing this out.

bouwkast and others added 5 commits September 18, 2024 13:08

Add DisabledAdoNetCommandTypes

c68ffea

Refactor Hashset generation

40ee64b

Co-authored-by: Lucas Pimentel <lucas.pimentel@datadoghq.com>

Manually update config_norm_rules

80565f8

Don't use the static Tracer.Instance

b3c9c3c

Revert "Don't use the static Tracer.Instance"

964c440

This reverts commit d34f2d0.

bouwkast requested review from a team as code owners September 18, 2024 17:14

Update snapshots - removes "language:dotnet" on v0

c4c7eae

language:dotnet was only added to all spans starting in V3.

bouwkast added the status:do-not-merge Work is done. Can review, but do not merge yet. label Sep 18, 2024

zacharycmontoya approved these changes Sep 18, 2024

View reviewed changes

lucaspimentel mentioned this pull request Sep 19, 2024

Add ability to disable additional ADO.NET Command Types #6042

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to disable additional ADO.NET Command Types (#6042 => v2) #6054

Add ability to disable additional ADO.NET Command Types (#6042 => v2) #6054

bouwkast commented Sep 18, 2024

bouwkast commented Sep 18, 2024

andrewlock commented Sep 18, 2024 •

edited

Loading

datadog-ddstaging bot commented Sep 18, 2024 •

edited

Loading

andrewlock commented Sep 18, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6054

Raw results

Faster 🎉 in #6054

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock commented Sep 18, 2024

bouwkast commented Sep 18, 2024 •

edited

Loading

Add ability to disable additional ADO.NET Command Types (#6042 => v2) #6054

Are you sure you want to change the base?

Add ability to disable additional ADO.NET Command Types (#6042 => v2) #6054

Conversation

bouwkast commented Sep 18, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

bouwkast commented Sep 18, 2024

andrewlock commented Sep 18, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Sep 18, 2024 • edited Loading

Datadog Report

andrewlock commented Sep 18, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6054

Raw results

Faster 🎉 in #6054

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock commented Sep 18, 2024

Throughput/Crank Report:zap:

bouwkast commented Sep 18, 2024 • edited Loading

andrewlock commented Sep 18, 2024 •

edited

Loading

datadog-ddstaging bot commented Sep 18, 2024 •

edited

Loading

bouwkast commented Sep 18, 2024 •

edited

Loading