[CI Visibility] Add vcpu_count tag to tslv events #6055

tonyredondo · 2024-09-19T13:02:05Z

Summary of changes

This PR adds the new _dd.host.vcpu_count tag to the test suite level visibility events in CI Visibility mode.

Reason for change

https://docs.google.com/document/d/1NhH9lg1MujAfeeSFQJY0Y-y6kxUDzqP0b7WtMA2FoxM/edit#heading=h.80nefriqhjyl

Test coverage

A new validation on the tests and update of the snapshots.

Other details

github-actions · 2024-09-19T13:09:05Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1520 occurrences of :

+      _dd.host.vcpu_count: 2.0,

datadog-ddstaging · 2024-09-19T13:34:15Z

Datadog Report

Branch report: tony/civisibility-send-cpu-count
Commit report: 3f1ddf3
Test service: dd-trace-dotnet

❌ 2 Failed (0 Known Flaky), 366774 Passed, 2051 Skipped, 16h 11m 13.69s Total Time
❄️ 1 New Flaky

❌ Failed Tests (2)

Injection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.SeleniumTests - Details

Expand for error

 
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: xunit.test,
     Resource: Samples.Selenium.TestSuite.SeleniumTest,
     Service: xunit-selenium-tests,
     Type: browser,
     TestSuiteId: Id_3,
 ...

Injection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.SeleniumTests - Details

Expand for error

 
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: xunit.test,
     Resource: Samples.Selenium.TestSuite.SeleniumTest,
     Service: xunit-selenium-tests,
     Type: browser,
     TestSuiteId: Id_3,
 ...

New Flaky Tests (1)

HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Last Failure

Expand for error

 
 Expected var integration = latestIntegrations {empty} to contain key "CurlHandler".), but no such item was found.t found False.

andrewlock · 2024-09-19T13:36:31Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6055) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6055) - mean (1,107ms)  : 1078, 1137
     .   : milestone, 1107,
    master - mean (1,078ms)  : 1055, 1101
     .   : milestone, 1078,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6055) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6055) - mean (774ms)  : 759, 789
     .   : milestone, 774,
    master - mean (748ms)  : 729, 766
     .   : milestone, 748,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6055) - mean (93ms)  : 89, 96
     .   : milestone, 93,
    master - mean (92ms)  : 89, 96
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6055) - mean (731ms)  : 716, 746
     .   : milestone, 731,
    master - mean (705ms)  : 690, 720
     .   : milestone, 705,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6055) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (192ms)  : 188, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6055) - mean (1,200ms)  : 1176, 1224
     .   : milestone, 1200,
    master - mean (1,174ms)  : 1147, 1201
     .   : milestone, 1174,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6055) - mean (278ms)  : 272, 283
     .   : milestone, 278,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6055) - mean (950ms)  : 933, 967
     .   : milestone, 950,
    master - mean (927ms)  : 905, 950
     .   : milestone, 927,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6055) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6055) - mean (933ms)  : 912, 953
     .   : milestone, 933,
    master - mean (906ms)  : 886, 926
     .   : milestone, 906,

andrewlock · 2024-09-19T16:27:24Z

Benchmarks Report for tracer 🐌

Benchmarks for #6055 compared to master:

1 benchmarks are faster, with geometric mean 1.123
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.68μs	41.3ns	226ns	0.0155	0.00774	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.87μs	55.3ns	379ns	0.0146	0.00488	0	5.62 KB
master	`StartStopWithChild`	net472	16.1μs	75.9ns	304ns	1.02	0.308	0.105	6.06 KB
#6055	`StartStopWithChild`	net6.0	7.86μs	44.6ns	309ns	0.0148	0.00371	0	5.43 KB
#6055	`StartStopWithChild`	netcoreapp3.1	9.83μs	53ns	275ns	0.0191	0.00477	0	5.61 KB
#6055	`StartStopWithChild`	net472	15.9μs	37.3ns	145ns	1.03	0.32	0.104	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	472μs	246ns	922ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	306ns	1.18μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	842μs	366ns	1.42μs	0.419	3.3 KB
#6055	`WriteAndFlushEnrichedTraces`	net6.0	457μs	218ns	846ns	0	2.7 KB
#6055	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	631μs	252ns	943ns	0	2.7 KB
#6055	`WriteAndFlushEnrichedTraces`	net472	836μs	479ns	1.79μs	0.414	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	200μs	1.18μs	11.8μs	0.191	18.45 KB
master	`SendRequest`	netcoreapp3.1	226μs	1.39μs	13.6μs	0.161	20.61 KB
master	`SendRequest`	net472	0.00066ns	0.000336ns	0.0013ns	0	0 b
#6055	`SendRequest`	net6.0	198μs	1.03μs	6.2μs	0.203	18.45 KB
#6055	`SendRequest`	netcoreapp3.1	220μs	1.27μs	10.2μs	0.211	20.61 KB
#6055	`SendRequest`	net472	0.001ns	0.000508ns	0.0019ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	568μs	1.93μs	7.46μs	0.573	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	709μs	3.76μs	18.4μs	0.355	0	0	41.71 KB
master	`WriteAndFlushEnrichedTraces`	net472	859μs	4.13μs	18μs	8.08	2.55	0.425	53.33 KB
#6055	`WriteAndFlushEnrichedTraces`	net6.0	550μs	1.94μs	6.72μs	0.601	0	0	41.44 KB
#6055	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	691μs	3.56μs	18.2μs	0.343	0	0	41.9 KB
#6055	`WriteAndFlushEnrichedTraces`	net472	842μs	2.47μs	8.92μs	8.41	2.4	0.401	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.2μs	0.847ns	3.17ns	0.0144	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.8μs	1.63ns	6.33ns	0.0136	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	2.54ns	9.49ns	0.156	987 B
#6055	`ExecuteNonQuery`	net6.0	1.22μs	1.34ns	5.03ns	0.0141	1.02 KB
#6055	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.51ns	5.84ns	0.0132	1.02 KB
#6055	`ExecuteNonQuery`	net472	2.14μs	1.59ns	6.17ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.2μs	0.492ns	1.84ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.987ns	3.69ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.46μs	2.12ns	8.2ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.29μs	0.845ns	3.27ns	0.0129	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.811ns	3.14ns	0.0141	1.02 KB
master	`CallElasticsearchAsync`	net472	2.68μs	2.55ns	9.89ns	0.166	1.05 KB
#6055	`CallElasticsearch`	net6.0	1.27μs	0.883ns	3.42ns	0.0134	976 B
#6055	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.867ns	3.36ns	0.0134	976 B
#6055	`CallElasticsearch`	net472	2.46μs	2.03ns	7.86ns	0.157	995 B
#6055	`CallElasticsearchAsync`	net6.0	1.24μs	0.754ns	2.82ns	0.0131	952 B
#6055	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.555ns	2ns	0.0141	1.02 KB
#6055	`CallElasticsearchAsync`	net472	2.64μs	1.68ns	6.5ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.39μs	0.681ns	2.55ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.55μs	1.56ns	6.04ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.88μs	0.607ns	2.35ns	0.145	915 B
#6055	`ExecuteAsync`	net6.0	1.28μs	0.97ns	3.76ns	0.0134	952 B
#6055	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.713ns	2.76ns	0.0129	952 B
#6055	`ExecuteAsync`	net472	1.72μs	0.409ns	1.47ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.2μs	4.68ns	17.5ns	0.0315	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.17μs	2.37ns	9.18ns	0.0362	2.76 KB
master	`SendAsync`	net472	7.78μs	2.76ns	10.7ns	0.5	3.15 KB
#6055	`SendAsync`	net6.0	4.11μs	2.24ns	8.4ns	0.0308	2.22 KB
#6055	`SendAsync`	netcoreapp3.1	5.17μs	2.81ns	10.5ns	0.0359	2.76 KB
#6055	`SendAsync`	net472	7.68μs	2.77ns	10.7ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	1.48ns	5.74ns	0.0235	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.3μs	1.26ns	4.9ns	0.0226	1.64 KB
master	`EnrichedLog`	net472	2.64μs	1.05ns	4.05ns	0.249	1.57 KB
#6055	`EnrichedLog`	net6.0	1.45μs	0.678ns	2.54ns	0.0232	1.64 KB
#6055	`EnrichedLog`	netcoreapp3.1	2.09μs	1.26ns	4.73ns	0.022	1.64 KB
#6055	`EnrichedLog`	net472	2.52μs	0.551ns	1.91ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	285ns	1.1μs	0.0564	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	123ns	461ns	0.0586	0	4.28 KB
master	`EnrichedLog`	net472	147μs	127ns	492ns	0.657	0.219	4.46 KB
#6055	`EnrichedLog`	net6.0	114μs	136ns	527ns	0.0571	0	4.28 KB
#6055	`EnrichedLog`	netcoreapp3.1	118μs	250ns	968ns	0.0593	0	4.28 KB
#6055	`EnrichedLog`	net472	147μs	177ns	686ns	0.663	0.221	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.2μs	1.08ns	4.19ns	0.0319	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.17μs	6.97ns	27ns	0.0291	2.2 KB
master	`EnrichedLog`	net472	4.76μs	0.981ns	3.8ns	0.319	2.02 KB
#6055	`EnrichedLog`	net6.0	3.06μs	0.722ns	2.8ns	0.0307	2.2 KB
#6055	`EnrichedLog`	netcoreapp3.1	4.19μs	2.08ns	8.07ns	0.0292	2.2 KB
#6055	`EnrichedLog`	net472	4.99μs	1.62ns	6.28ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.42μs	0.698ns	2.7ns	0.0156	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	0.942ns	3.65ns	0.0162	0	1.14 KB
master	`SendReceive`	net472	2.07μs	1.39ns	5.21ns	0.183	0	1.16 KB
#6055	`SendReceive`	net6.0	1.29μs	0.675ns	2.52ns	0.0162	0	1.14 KB
#6055	`SendReceive`	netcoreapp3.1	1.68μs	5.38ns	20.8ns	0.0158	0	1.14 KB
#6055	`SendReceive`	net472	2.12μs	0.949ns	3.68ns	0.183	0.00106	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.71μs	0.923ns	3.57ns	0.0228	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.87μs	1.19ns	4.6ns	0.0212	1.65 KB
master	`EnrichedLog`	net472	4.36μs	2.21ns	8.56ns	0.323	2.04 KB
#6055	`EnrichedLog`	net6.0	2.8μs	0.711ns	2.75ns	0.0224	1.6 KB
#6055	`EnrichedLog`	netcoreapp3.1	3.96μs	1.54ns	5.76ns	0.0218	1.65 KB
#6055	`EnrichedLog`	net472	4.4μs	2.29ns	8.27ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6055

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.123	872.91	777.24

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	408ns	0.463ns	1.79ns	0.00805	576 B
master	`StartFinishSpan`	netcoreapp3.1	578ns	0.617ns	2.39ns	0.00784	576 B
master	`StartFinishSpan`	net472	689ns	0.685ns	2.65ns	0.0916	578 B
master	`StartFinishScope`	net6.0	472ns	0.194ns	0.728ns	0.00974	696 B
master	`StartFinishScope`	netcoreapp3.1	790ns	0.537ns	2.08ns	0.00964	696 B
master	`StartFinishScope`	net472	874ns	0.905ns	3.5ns	0.104	658 B
#6055	`StartFinishSpan`	net6.0	406ns	0.316ns	1.18ns	0.00802	576 B
#6055	`StartFinishSpan`	netcoreapp3.1	620ns	1.41ns	5.46ns	0.00769	576 B
#6055	`StartFinishSpan`	net472	641ns	0.778ns	3.01ns	0.0915	578 B
#6055	`StartFinishScope`	net6.0	489ns	0.263ns	1.02ns	0.0098	696 B
#6055	`StartFinishScope`	netcoreapp3.1	771ns	0.662ns	2.56ns	0.00958	696 B
#6055	`StartFinishScope`	net472	777ns	0.597ns	2.31ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	605ns	0.223ns	0.863ns	0.00977	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.03μs	0.494ns	1.91ns	0.00923	696 B
master	`RunOnMethodBegin`	net472	1.1μs	0.596ns	2.15ns	0.105	658 B
#6055	`RunOnMethodBegin`	net6.0	624ns	0.356ns	1.38ns	0.0098	696 B
#6055	`RunOnMethodBegin`	netcoreapp3.1	953ns	1.74ns	6.76ns	0.00947	696 B
#6055	`RunOnMethodBegin`	net472	1.12μs	0.448ns	1.73ns	0.104	658 B

andrewlock · 2024-09-19T16:35:51Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6055) (11.158M)   : 0, 11157660
    master (11.055M)   : 0, 11055201
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6055) (7.287M)   : 0, 7286955
    master (7.305M)   : 0, 7305302
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.719M)   : 0, 7718644

    section Manual
    master (11.176M)   : 0, 11175778

    section Manual + Automatic
    This PR (6055) (6.694M)   : 0, 6694227
    master (6.751M)   : 0, 6751175

    section DD_TRACE_ENABLED=0
    master (10.283M)   : 0, 10283286

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6055) (9.496M)   : 0, 9495588
    master (9.522M)   : 0, 9522238
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6055) (6.708M)   : 0, 6708234
    master (6.585M)   : 0, 6585219

    section Trace stats
    master (6.719M)   : 0, 6718679

    section Manual
    master (9.695M)   : 0, 9695137

    section Manual + Automatic
    This PR (6055) (5.961M)   : 0, 5960927
    master (6.146M)   : 0, 6146480

    section DD_TRACE_ENABLED=0
    master (8.894M)   : 0, 8893665

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6055) (10.027M)   : 0, 10026575
    master (9.812M)   : 0, 9812220
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6055) (6.554M)   : 0, 6554326
    master (6.417M)   : 0, 6417355
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.155M)   : 0, 7155211

    section Manual
    master (9.839M)   : 0, 9839498

    section Manual + Automatic
    This PR (6055) (6.083M)   : 0, 6083386
    master (5.948M)   : 0, 5948081

    section DD_TRACE_ENABLED=0
    master (9.155M)   : 0, 9154793

[CI Visibility] Add vcpu_count tag to tslv events

8ceb713

tonyredondo self-assigned this Sep 19, 2024

Merge branch 'master' into tony/civisibility-send-cpu-count

40e24ea

github-actions bot added the area:ci-visibility label Sep 19, 2024

Snapshots update

ac13d0b

DataDog deleted a comment from github-actions bot Sep 19, 2024

tonyredondo marked this pull request as ready for review September 19, 2024 13:34

tonyredondo requested review from a team as code owners September 19, 2024 13:34

tonyredondo added 2 commits September 19, 2024 16:34

update snapshots

9f95737

Merge branch 'master' into tony/civisibility-send-cpu-count

3f1ddf3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI Visibility] Add vcpu_count tag to tslv events #6055

[CI Visibility] Add vcpu_count tag to tslv events #6055

tonyredondo commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Sep 19, 2024 •

edited

Loading

andrewlock commented Sep 19, 2024 •

edited

Loading

andrewlock commented Sep 19, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6055

Raw results

Raw results

andrewlock commented Sep 19, 2024

[CI Visibility] Add vcpu_count tag to tslv events #6055

Are you sure you want to change the base?

[CI Visibility] Add vcpu_count tag to tslv events #6055

Conversation

tonyredondo commented Sep 19, 2024 • edited Loading

Summary of changes

Reason for change

Test coverage

Other details

github-actions bot commented Sep 19, 2024 • edited Loading

Snapshots difference summary

datadog-ddstaging bot commented Sep 19, 2024 • edited Loading

Datadog Report

❌ Failed Tests (2)

New Flaky Tests (1)

andrewlock commented Sep 19, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Sep 19, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6055

Raw results

Raw results

andrewlock commented Sep 19, 2024

Throughput/Crank Report ⚡

tonyredondo commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Sep 19, 2024 •

edited

Loading

andrewlock commented Sep 19, 2024 •

edited

Loading