Add BundleWiring instrumentation to improve tracer behaviour on OSGi #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcculls
commented
Jan 21, 2021
•
mcculls
commented
- Rework our class-file location strategy to make it easier to mark agent requests
- Record the type of agent class-loader requests to help with OSGi instrumentation
- Support lightweight probing for class-loader matching that doesn't trigger additional bundle resolution
- Widen class/resource lookup for failing agent requests by checking any bundles wired as dependencies
...i-4.3/src/main/java/datadog/trace/instrumentation/osgi43/BundleReferenceInstrumentation.java
Outdated
Show resolved
Hide resolved
mcculls
force-pushed
the
mcculls/osgiInstrumentation
branch
9 times, most recently
from
568f688
to
77e3ab3
Compare
mcculls
force-pushed
the
mcculls/osgiInstrumentation
branch
from
77e3ab3
to
0bcc153
Compare
* Rework our class-file location strategy to make it easier to mark agent requests * Record the type of agent class-loader requests to help with OSGi instrumentation * Widen class/resource lookup on OSGi for agent requests (and support lightweight probing) * Enable checks for common OSGi issues in the OSGi smoke test
mcculls
force-pushed
the
mcculls/osgiInstrumentation
branch
from
0bcc153
to
1f1c037
Compare
richardstartin
approved these changes
Jan 27, 2021
tylerbenson
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.