Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't notify scope listeners if trace is eligible for dropping #2661

Merged
merged 2 commits into from
May 4, 2021
Merged

don't notify scope listeners if trace is eligible for dropping #2661

merged 2 commits into from
May 4, 2021

Conversation

richardstartin
Copy link
Member

No description provided.

@richardstartin richardstartin requested a review from a team as a code owner April 27, 2021 14:43
@richardstartin richardstartin marked this pull request as draft April 27, 2021 14:56
@richardstartin richardstartin force-pushed the rgs/sampling-aware-scope-listeners branch from 0f58f93 to c461244 Compare April 29, 2021 08:26
@richardstartin richardstartin marked this pull request as ready for review April 29, 2021 09:29
bantonsson
bantonsson approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny that you're using that byte for flags. I happen to be doing the exact same thing for other purposes in my experiments...

bantonsson
bantonsson requested changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a quick discussion about the implications on other listeners than profiling?

@richardstartin richardstartin force-pushed the rgs/sampling-aware-scope-listeners branch from c461244 to c8eb1e7 Compare April 29, 2021 15:53
@bantonsson
Copy link
Contributor

Is there anything holding this back, or can it be merged?

@richardstartin
Copy link
Member Author

@bantonsson if you have changes in this area, please don't hold back to avoid a merge conflict.

@bantonsson
Copy link
Contributor

Ok. The only overlap is the flags field. I'll align the naming.

@richardstartin richardstartin merged commit dae508a into master May 4, 2021
@richardstartin richardstartin deleted the rgs/sampling-aware-scope-listeners branch May 4, 2021 13:17
@github-actions github-actions bot added this to the 0.80.0 milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

@jbachorik jbachorik jbachorik approved these changes

@bantonsson bantonsson bantonsson approved these changes

@charliegracie charliegracie charliegracie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@richardstartin @bantonsson @tylerbenson @jbachorik @charliegracie