Invert control when defining transformers #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly reduces the number of maps that need to be constructed and avoids the risk of sizing incorrectly.
tylerbenson
added
the
tag: no release notes
tylerbenson
commented
Apr 29, 2021
Comment on lines
-50
to
-59
| public Map<? extends ElementMatcher<? super MethodDescription>, String> transformers() { | ||
| Map<ElementMatcher<? super MethodDescription>, String> transformers = new HashMap<>(); | ||
| transformers.put(isConstructor(), getClass().getName() + "$CaptureParentSpanAdvice"); | ||
| transformers.put( | ||
| public void adviceTransformations(AdviceTransformation transformation) { | ||
| transformation.applyAdvice(isConstructor(), getClass().getName() + "$CaptureParentSpanAdvice"); | ||
| transformation.applyAdvice( | ||
| isMethod() | ||
| .and(named("subscribe")) | ||
| .and(takesArguments(1)) | ||
| .and(takesArgument(0, named("io.reactivex.Observer"))), | ||
| getClass().getName() + "$PropagateParentSpanAdvice"); | ||
| return transformers; |
There was a problem hiding this comment.
This is a demonstration of the expected change required for each instrumenter.
richardstartin
approved these changes
Apr 30, 2021
bantonsson
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly reduces the number of maps that need to be constructed and avoids the risk of sizing incorrectly.
This is just a preliminary step. The stated benefits won't apply until subclasses have migrated.