Remove `version` metadata for non `DD_SERVICE` spans #7661

mhlidd · 2024-09-20T19:58:39Z

What Does This Do

Remove the version tag from span metadata when the span's service tag is not the same as the DD_SERVICE set from the configuration.

Motivation

Our goal is to make the implementation of configuration variables consistent for all languages as part of the config consistency effort listed in the following RFC. The expected behavior for the DD_VERSION config is to apply the value to all spans iff the service value of the span is DD_SERVICE.

Additional Notes

Testing for the functionality of this feature is done in the system-tests repository.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-475

pr-commenter · 2024-09-20T20:18:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/DD_VERSION
git_commit_date	1726854298	1726861175
git_commit_sha	`aa45861`	`f83aa0c`
release_version	1.40.0-SNAPSHOT~aa45861fa7	1.40.0-SNAPSHOT~f83aa0cdd4

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1726863459	1726863459
ci_job_id	647093969	647093969
ci_pipeline_id	44833747	44833747
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 12 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:iast:AppSec	better [-6.707ms; -1.622ms] or [-11.987%; -2.900%]	51.787ms	55.952ms

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065786
Total [baseline] (10.401 s) : 0, 10400618
Agent [candidate] (1.066 s) : 0, 1066391
Total [candidate] (10.355 s) : 0, 10355004
section appsec
Agent [baseline] (1.202 s) : 0, 1202365
Total [baseline] (10.644 s) : 0, 10643967
Agent [candidate] (1.205 s) : 0, 1205145
Total [candidate] (10.615 s) : 0, 10614660
section iast
Agent [baseline] (1.191 s) : 0, 1191389
Total [baseline] (10.828 s) : 0, 10827954
Agent [candidate] (1.194 s) : 0, 1194115
Total [candidate] (10.874 s) : 0, 10874142
section profiling
Agent [baseline] (1.266 s) : 0, 1266392
Total [baseline] (10.63 s) : 0, 10629767
Agent [candidate] (1.282 s) : 0, 1282262
Total [candidate] (10.613 s) : 0, 10613234

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	appsec	1.202 s	136.58 ms (12.8%)
Agent	iast	1.191 s	125.603 ms (11.8%)
Agent	profiling	1.266 s	200.606 ms (18.8%)
Total	tracing	10.401 s	-
Total	appsec	10.644 s	243.349 ms (2.3%)
Total	iast	10.828 s	427.337 ms (4.1%)
Total	profiling	10.63 s	229.149 ms (2.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	appsec	1.205 s	138.754 ms (13.0%)
Agent	iast	1.194 s	127.724 ms (12.0%)
Agent	profiling	1.282 s	215.871 ms (20.2%)
Total	tracing	10.355 s	-
Total	appsec	10.615 s	259.656 ms (2.5%)
Total	iast	10.874 s	519.138 ms (5.0%)
Total	profiling	10.613 s	258.23 ms (2.5%)

gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.535 ms) : 0, 679535
BytebuddyAgent [candidate] (679.682 ms) : 0, 679682
GlobalTracer [baseline] (310.635 ms) : 0, 310635
GlobalTracer [candidate] (311.362 ms) : 0, 311362
AppSec [baseline] (53.699 ms) : 0, 53699
AppSec [candidate] (53.458 ms) : 0, 53458
Remote Config [baseline] (669.714 µs) : 0, 670
Remote Config [candidate] (660.828 µs) : 0, 661
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (7.537 ms) : 0, 7537
section appsec
BytebuddyAgent [baseline] (702.475 ms) : 0, 702475
BytebuddyAgent [candidate] (703.451 ms) : 0, 703451
GlobalTracer [baseline] (304.191 ms) : 0, 304191
GlobalTracer [candidate] (304.656 ms) : 0, 304656
AppSec [baseline] (163.172 ms) : 0, 163172
AppSec [candidate] (163.719 ms) : 0, 163719
IAST [baseline] (19.616 ms) : 0, 19616
IAST [candidate] (19.804 ms) : 0, 19804
Remote Config [baseline] (637.022 µs) : 0, 637
Remote Config [candidate] (635.172 µs) : 0, 635
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (9.089 ms) : 0, 9089
section iast
BytebuddyAgent [baseline] (792.186 ms) : 0, 792186
BytebuddyAgent [candidate] (793.666 ms) : 0, 793666
GlobalTracer [baseline] (299.798 ms) : 0, 299798
GlobalTracer [candidate] (299.905 ms) : 0, 299905
AppSec [baseline] (55.952 ms) : 0, 55952
AppSec [candidate] (51.787 ms) : 0, 51787
IAST [baseline] (21.819 ms) : 0, 21819
IAST [candidate] (27.12 ms) : 0, 27120
Remote Config [baseline] (589.756 µs) : 0, 590
Remote Config [candidate] (600.018 µs) : 0, 600
Telemetry [baseline] (7.385 ms) : 0, 7385
Telemetry [candidate] (7.348 ms) : 0, 7348
section profiling
BytebuddyAgent [baseline] (673.181 ms) : 0, 673181
BytebuddyAgent [candidate] (683.19 ms) : 0, 683190
GlobalTracer [baseline] (395.232 ms) : 0, 395232
GlobalTracer [candidate] (399.815 ms) : 0, 399815
AppSec [baseline] (54.475 ms) : 0, 54475
AppSec [candidate] (54.999 ms) : 0, 54999
Remote Config [baseline] (646.145 µs) : 0, 646
Remote Config [candidate] (687.841 µs) : 0, 688
Telemetry [baseline] (7.45 ms) : 0, 7450
Telemetry [candidate] (7.562 ms) : 0, 7562
ProfilingAgent [baseline] (97.301 ms) : 0, 97301
ProfilingAgent [candidate] (97.374 ms) : 0, 97374
Profiling [baseline] (97.325 ms) : 0, 97325
Profiling [candidate] (97.398 ms) : 0, 97398

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063499
Total [baseline] (8.539 s) : 0, 8538750
Agent [candidate] (1.072 s) : 0, 1071805
Total [candidate] (8.549 s) : 0, 8549426
section iast
Agent [baseline] (1.19 s) : 0, 1190332
Total [baseline] (9.003 s) : 0, 9002603
Agent [candidate] (1.192 s) : 0, 1191824
Total [candidate] (9.005 s) : 0, 9004501
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.194 s) : 0, 1193685
Total [baseline] (9.01 s) : 0, 9009890
Agent [candidate] (1.193 s) : 0, 1192618
Total [candidate] (8.965 s) : 0, 8965474
section iast_TELEMETRY_OFF
Agent [baseline] (1.195 s) : 0, 1194804
Total [baseline] (9.013 s) : 0, 9012592
Agent [candidate] (1.192 s) : 0, 1191731
Total [candidate] (9.043 s) : 0, 9043025

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	iast	1.19 s	126.833 ms (11.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.194 s	130.186 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.195 s	131.305 ms (12.3%)
Total	tracing	8.539 s	-
Total	iast	9.003 s	463.854 ms (5.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.01 s	471.14 ms (5.5%)
Total	iast_TELEMETRY_OFF	9.013 s	473.842 ms (5.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.072 s	-
Agent	iast	1.192 s	120.02 ms (11.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.193 s	120.814 ms (11.3%)
Agent	iast_TELEMETRY_OFF	1.192 s	119.927 ms (11.2%)
Total	tracing	8.549 s	-
Total	iast	9.005 s	455.074 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.965 s	416.048 ms (4.9%)
Total	iast_TELEMETRY_OFF	9.043 s	493.598 ms (5.8%)

gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.242 ms) : 0, 678242
BytebuddyAgent [candidate] (683.674 ms) : 0, 683674
GlobalTracer [baseline] (309.903 ms) : 0, 309903
GlobalTracer [candidate] (312.272 ms) : 0, 312272
AppSec [baseline] (53.556 ms) : 0, 53556
AppSec [candidate] (53.831 ms) : 0, 53831
Remote Config [baseline] (667.611 µs) : 0, 668
Remote Config [candidate] (669.084 µs) : 0, 669
Telemetry [baseline] (7.536 ms) : 0, 7536
Telemetry [candidate] (7.636 ms) : 0, 7636
section iast
BytebuddyAgent [baseline] (791.817 ms) : 0, 791817
BytebuddyAgent [candidate] (792.765 ms) : 0, 792765
GlobalTracer [baseline] (299.115 ms) : 0, 299115
GlobalTracer [candidate] (299.651 ms) : 0, 299651
AppSec [baseline] (55.816 ms) : 0, 55816
AppSec [candidate] (55.25 ms) : 0, 55250
IAST [baseline] (21.891 ms) : 0, 21891
IAST [candidate] (22.602 ms) : 0, 22602
Remote Config [baseline] (602.171 µs) : 0, 602
Remote Config [candidate] (591.721 µs) : 0, 592
Telemetry [baseline] (7.403 ms) : 0, 7403
Telemetry [candidate] (7.3 ms) : 0, 7300
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.284 ms) : 0, 793284
BytebuddyAgent [candidate] (793.505 ms) : 0, 793505
GlobalTracer [baseline] (300.121 ms) : 0, 300121
GlobalTracer [candidate] (299.292 ms) : 0, 299292
AppSec [baseline] (54.617 ms) : 0, 54617
AppSec [candidate] (53.838 ms) : 0, 53838
IAST [baseline] (23.825 ms) : 0, 23825
IAST [candidate] (24.303 ms) : 0, 24303
Remote Config [baseline] (642.308 µs) : 0, 642
Remote Config [candidate] (598.607 µs) : 0, 599
Telemetry [baseline] (7.507 ms) : 0, 7507
Telemetry [candidate] (7.374 ms) : 0, 7374
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.218 ms) : 0, 794218
BytebuddyAgent [candidate] (793.419 ms) : 0, 793419
GlobalTracer [baseline] (300.95 ms) : 0, 300950
GlobalTracer [candidate] (299.456 ms) : 0, 299456
AppSec [baseline] (55.4 ms) : 0, 55400
AppSec [candidate] (55.855 ms) : 0, 55855
IAST [baseline] (21.729 ms) : 0, 21729
IAST [candidate] (20.62 ms) : 0, 20620
Remote Config [baseline] (1.391 ms) : 0, 1391
Remote Config [candidate] (1.367 ms) : 0, 1367
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.276 ms) : 0, 7276

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-09-20T19:48:15	2024-09-20T19:55:07
git_branch	master	mhlidd/DD_VERSION
git_commit_date	1726854298	1726861175
git_commit_sha	`aa45861`	`f83aa0c`
release_version	1.40.0-SNAPSHOT~aa45861fa7	1.40.0-SNAPSHOT~f83aa0cdd4
start_time	2024-09-20T19:48:01	2024-09-20T19:54:54

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1726862456	1726862456
ci_job_id	647093970	647093970
ci_pipeline_id	44833747	44833747
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.231 µs) : 351, 392
.   : milestone, 371,
iast (495.498 µs) : 474, 517
.   : milestone, 495,
iast_FULL (560.266 µs) : 539, 582
.   : milestone, 560,
iast_GLOBAL (513.844 µs) : 493, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (495.139 µs) : 474, 517
.   : milestone, 495,
iast_INACTIVE (460.393 µs) : 439, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (479.357 µs) : 457, 502
.   : milestone, 479,
tracing (448.498 µs) : 428, 469
.   : milestone, 448,
section candidate
no_agent (372.836 µs) : 353, 392
.   : milestone, 373,
iast (485.029 µs) : 464, 506
.   : milestone, 485,
iast_FULL (559.544 µs) : 538, 581
.   : milestone, 560,
iast_GLOBAL (525.115 µs) : 502, 549
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (489.338 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (449.906 µs) : 429, 470
.   : milestone, 450,
iast_TELEMETRY_OFF (481.627 µs) : 459, 504
.   : milestone, 482,
tracing (444.707 µs) : 424, 465
.   : milestone, 445,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.231 µs [350.89 µs, 391.572 µs]	-
iast	495.498 µs [474.058 µs, 516.938 µs]	124.266 µs (33.5%)
iast_FULL	560.266 µs [539.029 µs, 581.503 µs]	189.035 µs (50.9%)
iast_GLOBAL	513.844 µs [492.695 µs, 534.994 µs]	142.613 µs (38.4%)
iast_HARDCODED_SECRET_DISABLED	495.139 µs [473.597 µs, 516.682 µs]	123.908 µs (33.4%)
iast_INACTIVE	460.393 µs [439.471 µs, 481.314 µs]	89.161 µs (24.0%)
iast_TELEMETRY_OFF	479.357 µs [456.949 µs, 501.765 µs]	108.126 µs (29.1%)
tracing	448.498 µs [428.27 µs, 468.725 µs]	77.266 µs (20.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.836 µs [353.274 µs, 392.398 µs]	-
iast	485.029 µs [464.01 µs, 506.049 µs]	112.193 µs (30.1%)
iast_FULL	559.544 µs [537.967 µs, 581.122 µs]	186.708 µs (50.1%)
iast_GLOBAL	525.115 µs [501.615 µs, 548.615 µs]	152.279 µs (40.8%)
iast_HARDCODED_SECRET_DISABLED	489.338 µs [468.09 µs, 510.587 µs]	116.502 µs (31.2%)
iast_INACTIVE	449.906 µs [429.406 µs, 470.405 µs]	77.069 µs (20.7%)
iast_TELEMETRY_OFF	481.627 µs [459.079 µs, 504.174 µs]	108.79 µs (29.2%)
tracing	444.707 µs [424.49 µs, 464.924 µs]	71.871 µs (19.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1318, 1359
.   : milestone, 1338,
appsec (1.726 ms) : 1702, 1751
.   : milestone, 1726,
appsec_no_iast (1.742 ms) : 1717, 1766
.   : milestone, 1742,
iast (1.49 ms) : 1467, 1513
.   : milestone, 1490,
profiling (1.493 ms) : 1470, 1517
.   : milestone, 1493,
tracing (1.478 ms) : 1454, 1503
.   : milestone, 1478,
section candidate
no_agent (1.333 ms) : 1315, 1352
.   : milestone, 1333,
appsec (1.729 ms) : 1705, 1752
.   : milestone, 1729,
appsec_no_iast (1.752 ms) : 1728, 1777
.   : milestone, 1752,
iast (1.491 ms) : 1469, 1513
.   : milestone, 1491,
profiling (1.495 ms) : 1471, 1518
.   : milestone, 1495,
tracing (1.484 ms) : 1460, 1508
.   : milestone, 1484,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.338 ms [1.318 ms, 1.359 ms]	-
appsec	1.726 ms [1.702 ms, 1.751 ms]	388.156 µs (29.0%)
appsec_no_iast	1.742 ms [1.717 ms, 1.766 ms]	403.401 µs (30.1%)
iast	1.49 ms [1.467 ms, 1.513 ms]	151.82 µs (11.3%)
profiling	1.493 ms [1.47 ms, 1.517 ms]	154.943 µs (11.6%)
tracing	1.478 ms [1.454 ms, 1.503 ms]	139.702 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.333 ms [1.315 ms, 1.352 ms]	-
appsec	1.729 ms [1.705 ms, 1.752 ms]	395.018 µs (29.6%)
appsec_no_iast	1.752 ms [1.728 ms, 1.777 ms]	418.929 µs (31.4%)
iast	1.491 ms [1.469 ms, 1.513 ms]	157.533 µs (11.8%)
profiling	1.495 ms [1.471 ms, 1.518 ms]	161.314 µs (12.1%)
tracing	1.484 ms [1.46 ms, 1.508 ms]	150.507 µs (11.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/DD_VERSION
git_commit_date	1726854298	1726861175
git_commit_sha	`aa45861`	`f83aa0c`
release_version	1.40.0-SNAPSHOT~aa45861fa7	1.40.0-SNAPSHOT~f83aa0cdd4

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1726863097	1726863097
ci_job_id	647093971	647093971
ci_pipeline_id	44833747	44833747
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.898 s) : 14898000, 14898000
.   : milestone, 14898000,
appsec (15.255 s) : 15255000, 15255000
.   : milestone, 15255000,
iast (19.029 s) : 19029000, 19029000
.   : milestone, 19029000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
.   : milestone, 18020000,
profiling (15.652 s) : 15652000, 15652000
.   : milestone, 15652000,
tracing (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
section candidate
no_agent (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,
appsec (15.268 s) : 15268000, 15268000
.   : milestone, 15268000,
iast (18.664 s) : 18664000, 18664000
.   : milestone, 18664000,
iast_GLOBAL (18.182 s) : 18182000, 18182000
.   : milestone, 18182000,
profiling (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
tracing (15.334 s) : 15334000, 15334000
.   : milestone, 15334000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.898 s [14.898 s, 14.898 s]	-
appsec	15.255 s [15.255 s, 15.255 s]	357.0 ms (2.4%)
iast	19.029 s [19.029 s, 19.029 s]	4.131 s (27.7%)
iast_GLOBAL	18.02 s [18.02 s, 18.02 s]	3.122 s (21.0%)
profiling	15.652 s [15.652 s, 15.652 s]	754.0 ms (5.1%)
tracing	14.971 s [14.971 s, 14.971 s]	73.0 ms (0.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.086 s [15.086 s, 15.086 s]	-
appsec	15.268 s [15.268 s, 15.268 s]	182.0 ms (1.2%)
iast	18.664 s [18.664 s, 18.664 s]	3.578 s (23.7%)
iast_GLOBAL	18.182 s [18.182 s, 18.182 s]	3.096 s (20.5%)
profiling	15.049 s [15.049 s, 15.049 s]	-37.0 ms (-0.2%)
tracing	15.334 s [15.334 s, 15.334 s]	248.0 ms (1.6%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~f83aa0cdd4, baseline=1.40.0-SNAPSHOT~aa45861fa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.316 ms) : 2276, 2357
.   : milestone, 2316,
iast (2.063 ms) : 2011, 2114
.   : milestone, 2063,
iast_GLOBAL (2.101 ms) : 2050, 2152
.   : milestone, 2101,
profiling (1.94 ms) : 1899, 1980
.   : milestone, 1940,
tracing (1.911 ms) : 1873, 1950
.   : milestone, 1911,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.323 ms) : 2282, 2364
.   : milestone, 2323,
iast (2.069 ms) : 2018, 2119
.   : milestone, 2069,
iast_GLOBAL (2.105 ms) : 2054, 2156
.   : milestone, 2105,
profiling (1.936 ms) : 1896, 1977
.   : milestone, 1936,
tracing (1.903 ms) : 1865, 1942
.   : milestone, 1903,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.464 ms [1.453 ms, 1.476 ms]	-
appsec	2.316 ms [2.276 ms, 2.357 ms]	852.206 µs (58.2%)
iast	2.063 ms [2.011 ms, 2.114 ms]	598.691 µs (40.9%)
iast_GLOBAL	2.101 ms [2.05 ms, 2.152 ms]	636.929 µs (43.5%)
profiling	1.94 ms [1.899 ms, 1.98 ms]	475.774 µs (32.5%)
tracing	1.911 ms [1.873 ms, 1.95 ms]	447.377 µs (30.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.457 ms, 1.48 ms]	-
appsec	2.323 ms [2.282 ms, 2.364 ms]	854.191 µs (58.2%)
iast	2.069 ms [2.018 ms, 2.119 ms]	599.992 µs (40.8%)
iast_GLOBAL	2.105 ms [2.054 ms, 2.156 ms]	636.087 µs (43.3%)
profiling	1.936 ms [1.896 ms, 1.977 ms]	467.245 µs (31.8%)
tracing	1.903 ms [1.865 ms, 1.942 ms]	434.543 µs (29.6%)

removing version for spans with non-DD_SERVICE spans

f83aa0c

mhlidd added type: enhancement comp: core Tracer core labels Sep 20, 2024

mhlidd requested a review from mtoffl01 September 20, 2024 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `version` metadata for non `DD_SERVICE` spans #7661

Remove `version` metadata for non `DD_SERVICE` spans #7661

mhlidd commented Sep 20, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Sep 20, 2024

Remove version metadata for non DD_SERVICE spans #7661

Are you sure you want to change the base?

Remove version metadata for non DD_SERVICE spans #7661

Conversation

mhlidd commented Sep 20, 2024 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Sep 20, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Remove `version` metadata for non `DD_SERVICE` spans #7661

Remove `version` metadata for non `DD_SERVICE` spans #7661

mhlidd commented Sep 20, 2024 •

edited by jira bot

Loading