Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Visibility: default service name extraction from URL repo incorrectly using rstrip('.git') #10554

Closed
romainkomorndatadog opened this issue Sep 7, 2024 · 1 comment
Closed

CI Visibility: default service name extraction from URL repo incorrectly using rstrip('.git') #10554

romainkomorndatadog opened this issue Sep 7, 2024 · 1 comment
Assignees
@romainkomorndatadog
Labels
CI App

Comments

@romainkomorndatadog
Copy link
Collaborator

Summary of problem

ddtrace.internal.ci_visibility.recorder._extract_repository_name_from_url improperly rstrip()s .git from the repo name.

Which version of dd-trace-py are you using?

Current as of at least 7633e20.

Which version of pip are you using?

Does not matter.

Which libraries and their versions are you using?

Does not matter.

How can we reproduce your problem?

Use any repo that ends in one or more of ., g, i, or t and see that they are stripped.

What is the result that you get?

test-environment -> test-environmen
fastapi -> fastap

What is the result that you expected?

test-environment -> test-environment
fastapi -> fastapi
@romainkomorndatadog romainkomorndatadog self-assigned this Sep 7, 2024
@romainkomorndatadog romainkomorndatadog mentioned this issue Sep 7, 2024
Merged
2 tasks
romainkomorndatadog added a commit that referenced this issue Sep 9, 2024
@romainkomorndatadog
fix(ci_visibility): properly strip .git from repo URL when getting re…
aa04928 
…po name (#10556)

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
github-actions bot pushed a commit that referenced this issue Sep 9, 2024
@romainkomorndatadog @github-actions
fix(ci_visibility): properly strip .git from repo URL when getting re…
89e5483 
…po name (#10556)

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit aa04928)
@github-actions github-actions bot mentioned this issue Sep 9, 2024
Merged
2 tasks
github-actions bot pushed a commit that referenced this issue Sep 9, 2024
@romainkomorndatadog @github-actions
fix(ci_visibility): properly strip .git from repo URL when getting re…
caa13c3 
…po name (#10556)

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit aa04928)
@github-actions github-actions bot mentioned this issue Sep 9, 2024
Merged
2 tasks
github-actions bot pushed a commit that referenced this issue Sep 9, 2024
@romainkomorndatadog @github-actions
fix(ci_visibility): properly strip .git from repo URL when getting re…
f27c0ad 
…po name (#10556)

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit aa04928)
@github-actions github-actions bot mentioned this issue Sep 9, 2024
Merged
2 tasks
github-actions bot pushed a commit that referenced this issue Sep 9, 2024
@romainkomorndatadog @github-actions
fix(ci_visibility): properly strip .git from repo URL when getting re…
269de71 
…po name (#10556)

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit aa04928)
@github-actions github-actions bot mentioned this issue Sep 9, 2024
Merged
2 tasks
romainkomorndatadog added a commit that referenced this issue Sep 9, 2024
@github-actions @romainkomorndatadog
fix(ci_visibility): properly strip .git from repo URL when getting re…
fa5db95 
…po name [backport 2.12] (#10561)

Backport aa04928 from #10556 to 2.12.

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
romainkomorndatadog added a commit that referenced this issue Sep 9, 2024
@github-actions @romainkomorndatadog
fix(ci_visibility): properly strip .git from repo URL when getting re…
3a43ef3 
…po name [backport 2.11] (#10560)

Backport aa04928 from #10556 to 2.11.

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
romainkomorndatadog added a commit that referenced this issue Sep 9, 2024
@github-actions @romainkomorndatadog
fix(ci_visibility): properly strip .git from repo URL when getting re…
d7e6c20 
…po name [backport 2.10] (#10559)

Backport aa04928 from #10556 to 2.10.

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
romainkomorndatadog added a commit that referenced this issue Sep 9, 2024
@github-actions @romainkomorndatadog
fix(ci_visibility): properly strip .git from repo URL when getting re…
7413051 
…po name [backport 2.9] (#10558)

Backport aa04928 from #10556 to 2.9.

Fixes issue #10554 where `rstrip` was being used to remove the `.git`
suffix from repo URLs, causing repo names that end in one or more of
`g`, `i`, or `t` to be incorrectly extracted. eg: `fastapi.git` ->
`fastap` or `test-environment` -> `test-environmen` .

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
@romainkomorndatadog
Copy link
Collaborator Author

Releases with this fix have gone out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romainkomorndatadog romainkomorndatadog

Labels
CI App
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romainkomorndatadog