Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): use byte pointer instead of c_char_p (#10428) #10441

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

christophe-papazian
Copy link
Contributor

Backport of #10428

(cherry picked from commit 46bb2a8)

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance
    policy

To improve waf bindings efficiency, use byte pointer instead of c_char_p
for string retrieval from libddwaf

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 46bb2a8)
@christophe-papazian christophe-papazian requested a review from a team as a code owner August 29, 2024 08:56
@christophe-papazian christophe-papazian added enhancement changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Aug 29, 2024
@christophe-papazian christophe-papazian enabled auto-merge (squash) August 29, 2024 08:56
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-10428-to-2.9
Commit report: 7fa8928
Test service: dd-trace-py

✅ 0 Failed, 110492 Passed, 2895 Skipped, 49m 52.01s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2024

Benchmarks

Benchmark execution time: 2024-08-29 10:01:00

Comparing candidate commit 7fa8928 in PR branch backport-10428-to-2.9 with baseline commit 151b7d7 in branch 2.9.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Sep 5, 2024
@christophe-papazian christophe-papazian merged commit f20d79c into 2.9 Sep 9, 2024
90 of 99 checks passed
@christophe-papazian christophe-papazian deleted the backport-10428-to-2.9 branch September 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants