Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci_visibility): support pytest 8.0.0 [backport 2.5] #8482

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

romainkomorndatadog
Copy link
Collaborator

@romainkomorndatadog romainkomorndatadog commented Feb 22, 2024

Backport 78d5b98 from #8357 to 2.5.

Addresses #8220 and fixes an issue with pytest 8.x and above
(brought by pytest-dev/pytest#11137 ) where pytest.Package objects no longer have an attached module attribute.

This also changes the testing matrix to include version ~=8.0, but maintains ~=7.0 as a separate testing environment.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@romainkomorndatadog romainkomorndatadog self-assigned this Feb 22, 2024
@romainkomorndatadog romainkomorndatadog changed the base branch from main to 2.5 February 22, 2024 10:15
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 22, 2024

Datadog Report

Branch report: backport-8357-to-2.5
Commit report: 6cd05d8
Test service: dd-trace-py

✅ 0 Failed, 28084 Passed, 9749 Skipped, 14m 49.78s Total duration (1h 38m 38.79s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 22, 2024

Benchmarks

Benchmark execution time: 2024-02-22 10:48:30

Comparing candidate commit 9aba07b in PR branch backport-8357-to-2.5 with baseline commit 0334372 in branch main.

Found 12 performance improvements and 19 performance regressions! Performance is the same for 164 metrics, 9 unstable metrics.

scenario:coreapiscenario-core_dispatch_with_results_no_listeners

  • 🟥 max_rss_usage [+784.620KB; +927.917KB] or [+2.755%; +3.258%]

scenario:coreapiscenario-get_item_missing

  • 🟥 max_rss_usage [+695.373KB; +854.144KB] or [+2.427%; +2.981%]

scenario:httppropagationextract-all_styles_all_headers

  • 🟥 max_rss_usage [+667.988KB; +874.156KB] or [+2.338%; +3.059%]

scenario:httppropagationextract-b3_single_headers

  • 🟥 max_rss_usage [+784.433KB; +958.415KB] or [+2.757%; +3.368%]

scenario:httppropagationextract-datadog_tracecontext_tracestate_propagated_on_trace_id_match

  • 🟩 max_rss_usage [-789.002KB; -595.855KB] or [-2.688%; -2.030%]

scenario:httppropagationextract-invalid_trace_id_header

  • 🟥 max_rss_usage [+632.924KB; +825.661KB] or [+2.209%; +2.882%]

scenario:httppropagationextract-none_propagation_style

  • 🟩 max_rss_usage [-909.828KB; -703.177KB] or [-3.111%; -2.405%]

scenario:httppropagationextract-valid_headers_all

  • 🟥 max_rss_usage [+615.618KB; +810.610KB] or [+2.148%; +2.828%]

scenario:httppropagationextract-wsgi_invalid_priority_header

  • 🟩 max_rss_usage [-780.339KB; -595.917KB] or [-2.661%; -2.032%]

scenario:httppropagationextract-wsgi_valid_headers_basic

  • 🟥 max_rss_usage [+618.148KB; +822.415KB] or [+2.161%; +2.875%]

scenario:httppropagationinject-with_all

  • 🟥 execution_time [+574.385ns; +679.692ns] or [+3.127%; +3.701%]

scenario:httppropagationinject-with_dd_origin

  • 🟥 execution_time [+469.847ns; +517.617ns] or [+3.979%; +4.384%]

scenario:httppropagationinject-with_priority_and_origin

  • 🟥 execution_time [+348.550ns; +418.397ns] or [+2.564%; +3.078%]

scenario:httppropagationinject-with_sampling_priority

  • 🟥 max_rss_usage [+630.857KB; +782.672KB] or [+2.203%; +2.733%]

scenario:httppropagationinject-with_tags

  • 🟥 execution_time [+312.402ns; +388.336ns] or [+2.321%; +2.885%]

scenario:httppropagationinject-with_tags_invalid

  • 🟥 execution_time [+522.092ns; +604.119ns] or [+3.386%; +3.918%]
  • 🟩 max_rss_usage [-792.876KB; -664.480KB] or [-2.704%; -2.266%]

scenario:httppropagationinject-with_tags_max_size

  • 🟥 execution_time [+323.452ns; +452.313ns] or [+2.146%; +3.000%]

scenario:otelspan-add-metrics

  • 🟥 execution_time [+44.461ms; +48.450ms] or [+16.527%; +18.010%]
  • 🟥 max_rss_usage [+3.135MB; +3.284MB] or [+6.954%; +7.284%]

scenario:otelspan-add-tags

  • 🟥 execution_time [+44.831ms; +48.787ms] or [+17.795%; +19.366%]
  • 🟥 max_rss_usage [+3.137MB; +3.297MB] or [+6.951%; +7.306%]

scenario:sethttpmeta-no-useragentvariant

  • 🟥 max_rss_usage [+647.195KB; +744.216KB] or [+2.230%; +2.565%]

scenario:sethttpmeta-obfuscation-regular-case-explicit-query

  • 🟩 max_rss_usage [-733.519KB; -621.847KB] or [-2.454%; -2.080%]

scenario:sethttpmeta-obfuscation-send-querystring-disabled

  • 🟩 max_rss_usage [-780.454KB; -667.073KB] or [-2.605%; -2.227%]

scenario:sethttpmeta-obfuscation-worst-case-explicit-query

  • 🟩 max_rss_usage [-804.884KB; -691.795KB] or [-2.686%; -2.308%]

scenario:sethttpmeta-obfuscation-worst-case-implicit-query

  • 🟩 max_rss_usage [-778.639KB; -669.707KB] or [-2.599%; -2.236%]

scenario:sethttpmeta-useragentvariant_exists_1

  • 🟩 max_rss_usage [-794.046KB; -673.551KB] or [-2.671%; -2.266%]

scenario:span-start-finish

  • 🟩 max_rss_usage [-705.237KB; -589.099KB] or [-2.402%; -2.007%]

scenario:tracer-large

  • 🟩 max_rss_usage [-1.201MB; -1.051MB] or [-3.964%; -3.468%]

scenario:tracer-small

  • 🟩 max_rss_usage [-970.265KB; -810.676KB] or [-3.312%; -2.767%]

@gnufede gnufede closed this Feb 22, 2024
@gnufede gnufede reopened this Feb 22, 2024
@romainkomorndatadog romainkomorndatadog merged commit 22fcb7f into 2.5 Feb 22, 2024
168 checks passed
@romainkomorndatadog romainkomorndatadog deleted the backport-8357-to-2.5 branch February 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants