Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iast): improve overhead control logic (#8452) #8494

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix(iast): improve overhead control logic (#8452) #8494

merged 2 commits into from
Feb 22, 2024

Commits on Feb 22, 2024

  1. fix(iast): improve overhead control logic (#8452) 

    IAST: Improve overhead control logic so the decision to analyze a
request is done at span start and is saved at the span level using the
core API. This should fix issues where requests were analyzed when they
shouldn't be and viceversa.

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 7e8aaac)
    @gnufede
    gnufede committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5cf79d9 View commit details
    Browse the repository at this point in the history

  2. Merge branch '2.5' into backport-8452-to-2.5

    @gnufede
    gnufede committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    f90965c View commit details
    Browse the repository at this point in the history