-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iast): ensure context is created for current span [backport 2.7] #8786
Conversation
IAST: Ensure context is created in the current span, as some tainting operations occur regardless of `oce.acquire_request`. Note: The bug was introduce in this PR: #8452 ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit fedf88e)
Datadog ReportBranch report: ✅ 0 Failed, 110459 Passed, 874 Skipped, 1h 52m 55.96s Total duration (6m 6.87s time saved) |
BenchmarksBenchmark execution time: 2024-04-03 18:42:51 Comparing candidate commit 21203f5 in PR branch Found 3 performance improvements and 2 performance regressions! Performance is the same for 196 metrics, 9 unstable metrics. scenario:httppropagationextract-empty_headers
scenario:httppropagationextract-invalid_priority_header
scenario:httppropagationextract-invalid_trace_id_header
scenario:httppropagationextract-large_header_no_matches
scenario:httppropagationextract-medium_header_no_matches
|
Backport fedf88e from #8772 to 2.7.
IAST: Ensure context is created in the current span, as some tainting operations occur regardless of
oce.acquire_request
.Note: The bug was introduce in this PR: #8452
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist