Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dbm for all mysql and postgres integrations #8935

Merged
merged 58 commits into from
Apr 18, 2024

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Apr 10, 2024

Adds DBM for all mysql and postgres integrations.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Apr 10, 2024

Datadog Report

Branch report: conti/enable-dbm-for-all-mysql-integrations
Commit report: 64e1abe
Test service: dd-trace-py

✅ 0 Failed, 7022 Passed, 166439 Skipped, 3h 0m 15.6s Total duration (8h 26m 25.99s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Apr 10, 2024

Benchmarks

Benchmark execution time: 2024-04-18 10:05:37

Comparing candidate commit db2bbe7 in PR branch conti/enable-dbm-for-all-mysql-integrations with baseline commit b1dab58 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 200 metrics, 9 unstable metrics.

scenario:flasksimple-appsec-get

  • 🟥 execution_time [+190.122µs; +252.468µs] or [+3.025%; +4.016%]

Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a failure in the asyncpg test suite that looks like it's probably related to this change. Other than that, looks good!

ddtrace/contrib/asyncpg/patch.py Show resolved Hide resolved
@wconti27 wconti27 enabled auto-merge (squash) April 18, 2024 10:06
@wconti27 wconti27 merged commit 32c7a12 into main Apr 18, 2024
160 checks passed
@wconti27 wconti27 deleted the conti/enable-dbm-for-all-mysql-integrations branch April 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants