Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulling configuration file #3749

Merged
merged 16 commits into from
Jan 15, 2019
Merged

Pulling configuration file #3749

merged 16 commits into from
Jan 15, 2019

Conversation

l0k0ms
Copy link
Contributor

@l0k0ms l0k0ms commented Jan 9, 2019

What does this PR do?

Refactors the update_pre_build() script in order to create a pull_config.yaml file that defines all content that is pulled and how it should be processed with the doc.

Motivation

Allowing to scrap more content for the doc moving forward.

Preview link

@l0k0ms l0k0ms added Architecture Everything related to the Doc backend WORK IN PROGRESS No review needed, it's a wip ;) Do Not Merge Just do not merge this PR :) labels Jan 9, 2019
@l0k0ms l0k0ms requested review from mstbbs and a team as code owners January 9, 2019 19:30
@l0k0ms l0k0ms removed Do Not Merge Just do not merge this PR :) WORK IN PROGRESS No review needed, it's a wip ;) labels Jan 9, 2019
@l0k0ms l0k0ms mentioned this pull request Jan 10, 2019
Merged
davidejones
davidejones approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@davidejones davidejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of format changes in this file so it was a bit trickier to see the changes.
I tested with a new cloned repo, using my github token and then using local repos and both worked fine. So this should be good to go.

@l0k0ms l0k0ms merged commit 64a27e8 into master Jan 15, 2019
@l0k0ms l0k0ms deleted the gus/pulling-configuration-file branch January 24, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidejones davidejones davidejones approved these changes

@mstbbs mstbbs Awaiting requested review from mstbbs

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0k0ms @davidejones