Skip to content

Commit

Permalink
Skip the test, not the fixture (#10802)
Browse files Browse the repository at this point in the history
  • Loading branch information
hithwen committed Dec 7, 2021
1 parent 503c0a2 commit 76a249c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions mysql/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from datadog_checks.dev.conditions import CheckDockerLogs

from . import common, tags
from .common import MYSQL_REPLICATION, requires_static_version
from .common import MYSQL_REPLICATION

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -249,7 +249,6 @@ def instance_error():
return {'host': common.HOST, 'user': 'unknown', 'pass': common.PASS, 'disable_generic_tags': 'true'}


@requires_static_version
@pytest.fixture(scope='session')
def version_metadata():
parts = MYSQL_VERSION.split('-')
Expand Down
3 changes: 2 additions & 1 deletion mysql/tests/test_mysql.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from datadog_checks.mysql import MySql

from . import common, tags, variables
from .common import MYSQL_REPLICATION, MYSQL_VERSION_PARSED
from .common import MYSQL_REPLICATION, MYSQL_VERSION_PARSED, requires_static_version


@pytest.mark.integration
Expand Down Expand Up @@ -291,6 +291,7 @@ def _test_optional_metrics(aggregator, optional_metrics):
assert before > after


@requires_static_version
@pytest.mark.integration
@pytest.mark.usefixtures('dd_environment')
def test_version_metadata(dd_run_check, instance_basic, datadog_agent, version_metadata):
Expand Down

0 comments on commit 76a249c

Please sign in to comment.