Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable bloat metrics #10406

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Add option to disable bloat metrics #10406

merged 1 commit into from
Oct 18, 2021

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Oct 12, 2021 •
edited
Loading

What does this PR do?

Adds option to disable bloat metrics if relations are enabled

Motivation

These metrics have a more specific use case and contain a lot of logic that not everyone will need when collecting basic relation metrics.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Oct 12, 2021 •
edited
Loading

Codecov Report

Merging #10406 (a84dec7) into master (a45344d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
postgres 91.71% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review October 18, 2021 02:12
@sarah-witt sarah-witt requested review from a team as code owners October 18, 2021 02:12
coignetp
coignetp requested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why default to false?

@sarah-witt
Copy link
Contributor Author

@coignetp I updated the description!

@sarah-witt sarah-witt merged commit add8a30 into master Oct 18, 2021
@sarah-witt sarah-witt deleted the sarah/bloat-config-option branch October 18, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

Assignees
No one assigned
Labels
documentation integration/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarah-witt @coignetp