Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kube_apiserver.etcd.db.total_size metric #10569

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

clamoriniere
Copy link
Contributor

@clamoriniere clamoriniere commented Nov 7, 2021

What does this PR do?

the kube_apiserver.etcd.db.total_size metric is a gauge representing
the total size of the etcd database file physically allocated in bytes.

Refs: #10472

Motivation

Implement the feature request: #10472

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #10569 (895dc5a) into master (763da12) will not change coverage.
The diff coverage is 100.00%.

Flag Coverage Δ
kube_apiserver_metrics 97.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@clamoriniere clamoriniere force-pushed the clamoriniere/k8s-apiserver-metrics-etcd branch from f68318a to 76cf0fc Compare November 8, 2021 08:38
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

ahmed-mez
ahmed-mez previously approved these changes Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

ahmed-mez
ahmed-mez previously approved these changes Nov 8, 2021
the `kube_apiserver.etcd.db.total_size` metric is a gauge representing
the total size of the etcd database file physically allocated in bytes.

Refs: #10472
check warning: The instance argument in the `check()` function is
going to be deprecated in Agent 6. Please use `self.instance` instead.
@clamoriniere clamoriniere merged commit 5455002 into master Nov 9, 2021
@clamoriniere clamoriniere deleted the clamoriniere/k8s-apiserver-metrics-etcd branch November 9, 2021 09:39
@yzhan289 yzhan289 changed the title feat: add kube_apiserver.etcd.db.total_size metric Add kube_apiserver.etcd.db.total_size metric Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants