Support new implementation of Windows performance counters on Python 3 #10716
+292
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
fanny-jiang
reviewed
Nov 24, 2021
|
|
||
|
|
||
| @requires_py2 | ||
| def test_check_legacy(aggregator, instance_refresh, dd_run_check): |
There was a problem hiding this comment.
Somewhat unrelated, I don't see refresh_counters (from instance_refresh) in the pdh_legacy config template. Is this expected? Will the config spec be updated with the new perf_counters template later?
fanny-jiang
approved these changes
Nov 30, 2021
cswatt
pushed a commit
that referenced
this pull request
Jan 5, 2022
#10716) * Support new implementation of Windows performance counters on Python 3 * address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #10504