Add server default group for all monitor special cases
#10976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ofek
approved these changes
Dec 30, 2021
alexandreolivier-dd
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
groupsfield is used as default grouping in service checks monitors. For some specific integrations we add theservertag in this grouping in the backend code to tackle edge cases where thehosttag is replaced byserver.This PR is meant to reflect these edge cases in the configuration of the integration, in order to deprecate this in the backend.
Motivation
Remove some edge cases in the backend code, and simplify the evaluator code.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached