Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IBM mq] Do not allow for empty values in configuration #11138

Merged
merged 8 commits into from
Jan 25, 2022
Merged

[IBM mq] Do not allow for empty values in configuration #11138

merged 8 commits into from
Jan 25, 2022

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jan 14, 2022 •
edited
Loading

No description provided.

@hithwen hithwen requested a review from a team as a code owner January 14, 2022 09:32
@ghost ghost added the integration/ibm_mq label Jan 14, 2022
yzhan289
yzhan289 previously approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just 1 small nit

ibm_mq/datadog_checks/ibm_mq/config_models/validators.py Outdated Show resolved Hide resolved
@hithwen hithwen requested a review from a team as a code owner January 17, 2022 10:40
@ghost ghost added the documentation label Jan 17, 2022
@hithwen hithwen requested a review from yzhan289 January 17, 2022 10:41
kayayarai
kayayarai reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review probably not required, but I spotted a spelling mistake in a param name

ibm_mq/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
ibm_mq/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
@hithwen @kayayarai
Apply suggestions from code review
418d36a 
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
@ghost ghost added the documentation label Jan 18, 2022
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@hithwen hithwen merged commit b12871b into master Jan 25, 2022
@hithwen hithwen deleted the js/ibm-mq-extra-validations branch January 25, 2022 12:33
@fanny-jiang fanny-jiang mentioned this pull request Feb 24, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayayarai kayayarai kayayarai left review comments

@coignetp coignetp coignetp approved these changes

@yzhan289 yzhan289 Awaiting requested review from yzhan289

Assignees
No one assigned
Labels
documentation integration/ibm_mq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hithwen @kayayarai @coignetp @yzhan289