Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect value-only application tags #11219

Merged
merged 9 commits into from
Feb 1, 2022
Merged

Collect value-only application tags #11219

merged 9 commits into from
Feb 1, 2022

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Currently the yarn integration will skip parsing application tags if they're not in key:value form.

Motivation

Value tags are technically valid tags and should be collected: see docs

Currently the logs are getting skipped and submitted as a long string

2022-01-26 16:02:51 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:124 in LogMessage) | yarn:c21bd3c1c88284c2 | (yarn.py:279) | Unable to split string luigiscript_name:dash_monitor_edge,livy-batch-0-5hmfsykz,user_email:data-science-eng with YARN application tags

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

yarn/tests/test_unit.py Outdated Show resolved Hide resolved
ChristineTChen and others added 3 commits January 26, 2022 15:25
Co-authored-by: Andrew Zhang <31313038+yzhan289@users.noreply.github.com>
@ofek
Copy link
Contributor

ofek commented Jan 26, 2022

@ofek ofek merged commit 7663dfa into master Feb 1, 2022
@ofek ofek deleted the cc/allow-tags branch February 1, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants