-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect value-only application tags #11219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhan289
requested changes
Jan 26, 2022
Co-authored-by: Andrew Zhang <31313038+yzhan289@users.noreply.github.com>
…into cc/allow-tags
sarah-witt
reviewed
Jan 28, 2022
sarah-witt
approved these changes
Jan 28, 2022
yzhan289
approved these changes
Feb 1, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the yarn integration will skip parsing application tags if they're not in
key:value
form.Motivation
Value tags are technically valid tags and should be collected: see docs
Currently the logs are getting skipped and submitted as a long string
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached