Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect liveness and readiness probe metrics #11682

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Collect liveness and readiness probe metrics #11682

merged 3 commits into from
Mar 22, 2022

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented Mar 16, 2022 •
edited
Loading

What does this PR do?

Generate new metrics based on the prober_probe_total metric exposed in the /metrics/probe endpoint

  • kubernetes.liveness_probe.success.total
  • kubernetes.liveness_probe.failure.total
  • kubernetes.readiness_probe.success.total
  • kubernetes.readiness_probe.failure.total

Motivation

Monitor liveness and readiness probes

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ahmed-mez ahmed-mez requested review from a team as code owners March 16, 2022 13:21
@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #11682 (639e9a2) into master (bba64f0) will decrease coverage by 0.00%.
The diff coverage is 87.82%.

Flag Coverage Δ
kubelet 90.28% <87.82%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

clamoriniere
clamoriniere previously approved these changes Mar 21, 2022
View reviewed changes
@ahmed-mez @hithwen
simplify get_container_label
bf12dc4 
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
@ahmed-mez ahmed-mez merged commit 2ca0940 into master Mar 22, 2022
@ahmed-mez ahmed-mez deleted the ahmed/kubelet-prober-merics branch March 22, 2022 15:30
@ahmed-mez ahmed-mez mentioned this pull request Apr 11, 2022
Merged
4 tasks
@Ramyak Ramyak mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clamoriniere clamoriniere clamoriniere approved these changes

@hithwen hithwen Awaiting requested review from hithwen

Assignees
No one assigned
Labels
documentation integration/kubelet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmed-mez @clamoriniere @hithwen