Bug fix: fix postgres activity inflated query durations #11765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new column to activity queries for postgres,
now
, which is collected by calling theclock_timestamp()
function. This will allow us to ingest the current time as seen by the database itself, and use that for our duration calculations for active queries in the backend.Motivation
For the postgres integration, we're setting duration as
payloadTimestamp - query_start
, but payloadTimestamp is now() as calculated by the agent. It should instead be clock_timestamp() as reported by the database when the activity query is made.This is likely adding 10-20 ms to our Postgres activity query durations.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached