Add a lock around jdbc connection #11877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jtappa
previously approved these changes
Apr 21, 2022
hithwen
added
do-not-merge/WIP
changelog/Fixed
and removed
changelog/no-changelog
labels
hithwen
force-pushed
the
js/AGENT-7456-jdbc-lock
branch
from
405b51f
to
4d444bf
Compare
justiniso
approved these changes
May 4, 2022
sarah-witt
approved these changes
May 5, 2022
A concurrency test would be hard to make reliable (the problem only appears when multiple instances are running simultaneously) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support case AGENT-7456.
A user is using five instances of this check and they were failing with this error:
The problem seems to be a limitation of jpype itself about running it on multiple threads so this change introduces a lock around creating a connection.
A more severe approach has been explored in #11882 but the user has tested the changes here and found the issue resolved.