Add retries to test & emit warnings when connections fail #12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
hithwen
changed the title
hithwen
changed the title
hithwen
force-pushed
the
js/add-attempts-to-sap-hanna
branch
from
9b1c2a0
to
3bec9bc
Compare
FlorentClarret
previously approved these changes
Jul 20, 2022
| aggregator = dd_agent_check(instance, rate=True) | ||
| while attempts and connection_flaked(aggregator): | ||
| aggregator = dd_agent_check(instance, rate=True) | ||
| attempts -= 1 |
There was a problem hiding this comment.
nit - in this case we have 4 attempts, not 3
FlorentClarret
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HANA connection some times flakes. In those cases either the client itself or the integration handle it gracefully but some or all metrics can be missing for a check run.
Example https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=105007&view=logs&j=b0ed5827-5770-56e3-9f82-70059854e6d2&t=879ef9f2-95c3-5e11-5b66-404511e0691a&l=663
This change introduces the following changes: