-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default configuration to collect postgres database by default #12999
Update default configuration to collect postgres database by default #12999
Conversation
Label |
2 similar comments
Label |
Label |
The |
f89599e
to
c55707e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…12999) * Update default configuration for collect_default_database to true * Fix unit test to account for the default db being included * Also update ignore_databases to reduce confusion
What does this PR do?
This PR aims to address confusion that comes up related to missing data due to the default
postgres
database being ignored. This updates the default configuration to enable data collection on the default database. We had talked about removingpostgres
from the defaultignored_databases
but sincecollect_default_database
also directly relates to it, I think it makes sense to update both configuration defaults. For reference, here's where thecollect_default_database
gets used and how it relates toignored_databases
: https://github.com/DataDog/integrations-core/blob/master/postgres/datadog_checks/postgres/config.py#L73-L74.Note that this is technically a breaking change because the collection behavior is going to change. We're going ahead with this change because it's going to be a better overall experience moving forward.
Motivation
Additional Notes
I validated the performance and impact of this on our integration environment. Note that I tested this change along with #12998 because they are both related to the same goal of reducing confusion regarding our data collection, going out at the same time. The material impact is that prior to both changes, query samples/activity was not collected on the default
postgres
database. With the two changes, they now are. And because query metric collection didn't honor theignore_databases
configuration before, query metrics on the defaultpostgres
database remains unchanged with the new default configuration.Here's a clearer way to see the impact. This shows the different behavior of 7.39.0 vs the version with the changes with one deployment using the default config and another one setting
collect_default_database
to false.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached