Postgres: Add postgres.snapshot.{xmin,xmax,xip_count} metric
#13777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
e4838b3
to
971d9a0
Compare
iliakur
previously approved these changes
Apr 6, 2023
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
971d9a0
to
19b6598
Compare
|
The |
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
9eddae2
to
bc59b4d
Compare
bonnefoa
changed the title
postgres.transactions.xid metric to report global txidpostgres.snapshot.{xmin,xmax,xip_count} metric
|
The |
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
bc59b4d
to
d652a5a
Compare
|
The |
2 similar comments
|
The |
|
The |
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
5 times, most recently
from
3cc3481
to
73dcd45
Compare
iliakur
previously approved these changes
Apr 27, 2023
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
3 times, most recently
from
bba5a7c
to
9455cee
Compare
iliakur
previously approved these changes
May 2, 2023
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
9455cee
to
b30fd27
Compare
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
b30fd27
to
d71fd9e
Compare
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
d71fd9e
to
f3fdc00
Compare
bonnefoa
force-pushed
the
bonnefoa/pg-snapshot-xmin
branch
from
f3fdc00
to
c2093f3
Compare
alexandre-normand
approved these changes
Jun 6, 2023
|
Looks like the rebase from master solved the tests being super slow and timing out. Merging this. And thank you, @bonnefoa ! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Report the global txid extracted from
pg_snapshot_xmax(pg_current_snapshot()).Motivation
This will provide a way to see the rate of txid consumption.
The current
postgresql.commitsonly provides visibility on commitswhich include both virtual and non-virtual transactions.
postgres.snapshot.xmaxonly reports transactions that wereassigned txid when they doing changes in the database.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.