Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add process signatures for cilium #14202

Merged
merged 2 commits into from
Apr 4, 2023
Merged

add process signatures for cilium #14202

merged 2 commits into from
Apr 4, 2023

Conversation

Janaeq
Copy link
Contributor

@Janaeq Janaeq commented Mar 21, 2023

What does this PR do?

Add Process signatures for Cilium

Motivation

https://datadoghq.atlassian.net/jira/software/c/projects/AI/boards/197?modal=detail&selectedIssue=AI-2891&assignee=61d602cda54af900697e79ba

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@Janaeq Janaeq requested review from a team as code owners March 21, 2023 21:07
alai97
alai97 previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs!

FlorentClarret
FlorentClarret requested changes Mar 22, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR.

Left one comment

istio/manifest.json Outdated
Comment on lines 49 to 52
},
"process_signatures": [
"istio"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this change since it belongs to your other PR? Thank you 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@FlorentClarret FlorentClarret merged commit 4e56d12 into master Apr 4, 2023
@FlorentClarret FlorentClarret deleted the AI-2891-process-signatures-cilium branch April 4, 2023 14:22
github-actions bot pushed a commit that referenced this pull request Apr 4, 2023
@FlorentClarret
add process signatures for cilium (#14202)
782b1c1 
* add process signatures for cilium

* remove istio process signature 4e56d12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@steveny91 steveny91 steveny91 approved these changes

@alai97 alai97 alai97 left review comments

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/cilium integration/istio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janaeq @FlorentClarret @steveny91 @alai97