Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubelet] Add node filesystem stat from stats/summary #14426

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

vboulineau
Copy link
Contributor

@vboulineau vboulineau commented Apr 20, 2023

What does this PR do?

Add following metrics to Kubelet check:

kubernetes.node.filesystem.usage
kubernetes.node.filesystem.usage_pct
kubernetes.node.image.filesystem.usage
kubernetes.node.image.filesystem.usage_pct

Based on filesystem stats available in /stats/summary. Especially useful on Windows where access to host filesystem metrics is not possible.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #14426 (e66575e) into master (85ab590) will increase coverage by 0.00%.
The diff coverage is 90.47%.

Flag Coverage Δ
kubelet 90.74% <90.47%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vboulineau vboulineau merged commit 92dcf1f into master Apr 28, 2023
@vboulineau vboulineau deleted the vboulineau/node-metrics branch April 28, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants