-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: reduce duplication, condense method implementation #14501
Refactor: reduce duplication, condense method implementation #14501
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
DatadogESHealth = namedtuple('DatadogESHealth', ['status', 'reverse_status', 'tag']) | ||
ES_HEALTH_TO_DD_STATUS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reviewer: I'm not happy with these names, alternatives welcome!
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
What does this PR do?
Motivation
We use essentially the same logic to convert ES health statuses to DD statuses in two places. This PR unifies the two approaches.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.