Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kube_apiserver_metrics] Rename aggregator_unavailable_apiservice name tag to apiservice_name (#14738) #14751

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[kube_apiserver_metrics] Rename aggregator_unavailable_apiservice name tag to apiservice_name (#14738) #14751

merged 1 commit into from
Jun 14, 2023

Conversation

FlorentClarret
Copy link
Member

What does this PR do?

Backport for #14738

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@AliDatadog @FlorentClarret
[kube_apiserver_metrics] Rename aggregator_unavailable_apiservice `na…
d323579 
…me` tag to `apiservice_name` (#14738)

* handle name tag properly

* new metrics transformer for aggregator_unavailable_apiservice which avoids conflicting  tag

* update dashboard

* rename submit_as_gauge_and_monotonic_count

(cherry picked from commit d30dd1c)
@FlorentClarret FlorentClarret requested review from a team as code owners June 14, 2023 07:25
@FlorentClarret FlorentClarret mentioned this pull request Jun 14, 2023
Closed
5 tasks
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@FlorentClarret FlorentClarret merged commit 0dde4bd into 7.46.x Jun 14, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/backport-7-46/ali/fix-apiservices-name branch June 14, 2023 07:30
@FlorentClarret FlorentClarret mentioned this pull request Jun 14, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
integration/kube_apiserver_metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentClarret @AliDatadog