Support custom queries #1528
Merged
Support custom queries #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
requested changes
May 14, 2018
| break | ||
|
|
||
| # Only submit metrics if there were absolutely no errors - all or nothing. | ||
| else: |
There was a problem hiding this comment.
I did not know about the else after a for loop. Pretty cool !
oracle/conf.yaml.example
Outdated
| # custom_queries: | ||
| # - metric_prefix: oracle.custom_query | ||
| # query: | # Use the pipe if you require a multi-line script. | ||
| # SELECT colums |
| for custom_query in custom_queries: | ||
| metric_prefix = custom_query.get('metric_prefix') | ||
| if not metric_prefix: | ||
| self.log.error('custom query field `metric_prefix` is required') |
There was a problem hiding this comment.
For all the error messages, can we find a way to identify to which query and/or column they refer to ? This would be easier to debug a config when there are several queries/columns. I'm thinking we could print the index of the query/column. What do you think ?
.travis.yml
Outdated
| @@ -68,7 +68,7 @@ env: | |||
| - TRAVIS_FLAVOR=mongo FLAVOR_VERSION=3.4 | |||
| - TRAVIS_FLAVOR=mongo FLAVOR_VERSION=3.5 | |||
| - TRAVIS_FLAVOR=openstack | |||
| # - TRAVIS_FLAVOR=oracle FLAVOR_VERSION=latest | |||
| - TRAVIS_FLAVOR=oracle FLAVOR_VERSION=latest | |||
There was a problem hiding this comment.
Testing is currently broken for oracle until I'm done with my work on it. No need to reenable the travis flavor.
| @@ -3,6 +3,7 @@ | |||
| # Licensed under Simplified BSD License (see LICENSE) | |||
|
|
|||
| # stdlib | |||
| from contextlib import closing | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Customer requests