-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Azure AD auth token in correct format #15701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zhengda
approved these changes
Aug 28, 2023
cswatt
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog approved by docs
FlorentClarret
approved these changes
Aug 29, 2023
vivek-datadog
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Return Azure AD auth token in correct format * changelog
3 tasks
vivek-datadog
added a commit
that referenced
this pull request
Aug 29, 2023
* Return Azure AD auth token in correct format (#15701) * [Release] Bumped postgres version to 14.2.1 * [Release] Update metadata --------- Co-authored-by: JoJo <jojo.meunier@datadoghq.com>
jmeunier28
added a commit
that referenced
this pull request
Sep 18, 2023
* Return Azure AD auth token in correct format * changelog
jmeunier28
added a commit
that referenced
this pull request
Sep 18, 2023
* Return Azure AD auth token in correct format * changelog
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a feature, which was added in #15609 to support Azure Managed Identity authentication for Postgresql Flex/Single Server.
The original implementation used a similar approach to sqlserver/
pyodbc
to set the token, but that was not necessary and resulted in the incorrect token being passed at connection time. I tested this by updating the code on a local install & was able to verify we are seeing all of the expected integration data for our test postgres instance now:Motivation
This feature was implemented as part of an effort to support more secure ways to authenticate to databases in the cloud. As we previously added support for IAM, this allows azure users to connect using managed authentication. This is a highly requested customer feature.