Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump psycopg2 version to adopt libpq 16 #15949

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Bump psycopg2 version to adopt libpq 16 #15949

merged 8 commits into from
Oct 16, 2023

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

This PR bumps psycopg2 to 2.9.8 in Postgres integration to adopt the most recent upgraded libpq v16.

Motivation

psycopg2 v2.9.8 includes libpq v16, which sets the path forward for supporting Postgres 16. This version is also a "backup" plan as we observed concerning performance degrade during psycopg2 to psycopg3 upgrade.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@ghost ghost added the integration/postgres label Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ghost ghost added the documentation label Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ghost ghost added the integration/pgbouncer label Oct 3, 2023
@lu-zhengda lu-zhengda marked this pull request as ready for review October 3, 2023 03:02
@lu-zhengda lu-zhengda requested review from a team as code owners October 3, 2023 03:02
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #15949 (da61a46) into master (5ba30fc) will increase coverage by 0.63%.
The diff coverage is 100.00%.

Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
pgbouncer 91.33% <ø> (ø)
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Test Results

       9 files         9 suites   16m 36s ⏱️
   247 tests    243 ✔️   4 💤 0 ❌
1 458 runs  1 401 ✔️ 57 💤 0 ❌

Results for commit da61a46.

♻️ This comment has been updated with latest results.

maycmlee
maycmlee previously approved these changes Oct 3, 2023
View reviewed changes
jmeunier28
jmeunier28 previously approved these changes Oct 3, 2023
View reviewed changes
@jmeunier28 jmeunier28 mentioned this pull request Oct 3, 2023
Closed
3 tasks
@lu-zhengda lu-zhengda dismissed stale reviews from jmeunier28 and maycmlee via 3d04ce7 October 13, 2023 14:54
jmeunier28
jmeunier28 previously approved these changes Oct 13, 2023
View reviewed changes
ofek
ofek requested changes Oct 13, 2023
View reviewed changes
postgres/CHANGELOG.md Outdated Show resolved Hide resolved
pgbouncer/CHANGELOG.md
@@ -2,6 +2,10 @@

## Unreleased

***Changed***:

* Upgrade `psycopg2-binary` to `v2.9.8` ([#15949](https://github.com/DataDog/integrations-core/pull/15949))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under Added and this entry should say dropped support for Python 2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need a Changed entry to document that Agent 6/Python 2 is no longer supported

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://datadoghq.dev/integrations-core/guidelines/pr/#changelog-entries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. changelog updated

datadog_checks_base/CHANGELOG.md Outdated Show resolved Hide resolved
@lu-zhengda lu-zhengda requested a review from ofek October 13, 2023 21:52
@lu-zhengda lu-zhengda merged commit 446874c into master Oct 16, 2023
37 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/libpq-bump branch October 16, 2023 14:00
@jmeunier28 jmeunier28 mentioned this pull request Oct 20, 2023
Merged
@FlorentClarret FlorentClarret mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@maycmlee maycmlee maycmlee left review comments

@jmeunier28 jmeunier28 jmeunier28 left review comments

Assignees
No one assigned
Labels
base_package changelog/no-changelog dependencies documentation integration/pgbouncer integration/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lu-zhengda @ofek @maycmlee @jmeunier28