Make dbm async job cancel non-blocking #16028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
jmeunier28
previously approved these changes
Oct 16, 2023
drichards-87
previously approved these changes
Oct 17, 2023
jmeunier28
previously approved these changes
Oct 17, 2023
lu-zhengda
dismissed stale reviews from jmeunier28 and drichards-87
via
ef7e0c9
drichards-87
approved these changes
Oct 17, 2023
jmeunier28
approved these changes
Oct 17, 2023
steveny91
approved these changes
Oct 17, 2023
steveny91
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Make db async job cancel non-blocking * add changelog * reorder changelog entry * use run_one_check to ensure check is properly cancelled * remove aggregator reset * remove logging _last_check_run because logging ts isn't helpful
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes dbm async job cancel non-blocking to resolve error
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.