[DBMON-3050] Collect dynamic relation metrics for autodiscovered databases #16076
Conversation
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
lu-zhengda
changed the title
| def execute_query_raw(self, query): | ||
| with self.db() as conn: | ||
| def execute_query_raw(self, query, db): | ||
| with db() as conn: |
There was a problem hiding this comment.
nice, i think we can do something similar in sqlserver to get rid of this stuff where we have to collect per database && have some weird logic around how we do that. Instead, we can use this same path to migrate the query executor in the sqlserver integration to run these queries across all databases. Just a thought !
There was a problem hiding this comment.
Yes. I also kinda want to "simplify" the way we switch db within the same connection for sqlserver. Ideally it's abstracted from metrics collection
What does this PR do?
This PR fixes issue relates to not collecting dynamic relation metrics for auto-discovered databases. One side effect of this issue is that the
table_sizeof auto-discovered tables are not populated in DBM Schema tab.After fix:
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.