Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL: Create postgresql.create_index.* metrics tracking progress of index creation #16330

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

bonnefoa
Copy link
Contributor

@bonnefoa bonnefoa commented Dec 4, 2023

What does this PR do?

Add metrics based on pg_stat_progress_create_index

Motivation

We want to be able to track the state of index/reindex (how many tuples processed...) and if an index command is blocked.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #16330 (88c7374) into master (185df30) will decrease coverage by 4.07%.
The diff coverage is 100.00%.

❗ Current head 88c7374 differs from pull request most recent head 6c6bcf1. Consider uploading reports for the commit 6c6bcf1 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
jboss_wildfly ?
postgres 92.29% <100.00%> (+0.04%) ⬆️
presto ?
solr ?
tomcat ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Dec 4, 2023

Test Results

     16 files       16 suites   19m 51s ⏱️
   266 tests    264 ✔️     2 💤 0
2 136 runs  2 032 ✔️ 104 💤 0

Results for commit 6c6bcf1.

♻️ This comment has been updated with latest results.

@nenadnoveljic nenadnoveljic merged commit acc3b44 into master Dec 12, 2023
40 checks passed
@nenadnoveljic nenadnoveljic deleted the bonnefoa/progress-index branch December 12, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants