Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #16394

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Update dependencies #16394

merged 2 commits into from
Dec 13, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Dec 11, 2023 •
edited
Loading

What does this PR do?

Update some of our dependencies

Motivation

Additional Notes

  • I reverted the cryptography bump as it break the centos 6 build. I'll check that next week
  • The Snowflake connector is now longer built in omnibus so there's no need to modify something on the agent side this time 🎉
  • Our tooling brought back some py2 deps on py3 only integrations (mostly DBM integrations). It's completely ok even if useless. I'll fix this later. We'll keep it for now so we do not keep fighting with our bot when it updates the deps automatically

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Merging #16394 (8807d05) into master (a271fa1) will increase coverage by 0.14%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ
activemq ?
amazon_msk 89.07% <ø> (ø)
cassandra ?
confluent_platform ?
datadog_checks_base 89.62% <ø> (+0.36%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 87.39% <ø> (+0.03%) ⬆️
postgres 92.24% <ø> (-0.01%) ⬇️
presto ?
snowflake 95.95% <ø> (ø)
solr ?
tomcat ?
vertica 98.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2023 •
edited
Loading

Test Results

     58 files       58 suites   44m 54s ⏱️
1 681 tests 1 662 ✔️   19 💤 0 ❌
8 278 runs  7 374 ✔️ 904 💤 0 ❌

Results for commit 8807d05.

♻️ This comment has been updated with latest results.

@FlorentClarret FlorentClarret marked this pull request as ready for review December 12, 2023 07:47
@FlorentClarret FlorentClarret requested review from a team as code owners December 12, 2023 07:47
lu-zhengda
lu-zhengda reviewed Dec 12, 2023
View reviewed changes
mysql/pyproject.toml
"cryptography==41.0.6; python_version > '3.0'",
"pymysql==0.10.1; python_version < '3.0'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to manually remove py2 deps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our tooling brought back some py2 deps on py3 only integrations (mostly DBM integrations). It's completely ok even if useless. I'll fix this later. We'll keep it for now so we do not keep fighting with our bot when it updates the deps automatically

@FlorentClarret FlorentClarret merged commit 12c5c76 into master Dec 13, 2023
56 of 58 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/bump_deps branch December 13, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zhengda lu-zhengda lu-zhengda approved these changes

@vivek-datadog vivek-datadog vivek-datadog approved these changes

Assignees
No one assigned
Labels
base_package dependencies integration/amazon_msk integration/cisco_aci integration/http_check integration/mysql integration/postgres integration/snowflake integration/tls integration/vertica team/agent-integrations team/database-monitoring-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorentClarret @lu-zhengda @vivek-datadog